Skip to content

Commit d89c7a7

Browse files
committed
fix: make public functions external in GraphProxyAdmin (C4 QA)
1 parent 289f328 commit d89c7a7

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

contracts/upgrades/GraphProxyAdmin.sol

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ contract GraphProxyAdmin is Governed {
2828
* @param _proxy Address of the proxy for which to get the implementation.
2929
* @return The address of the current implementation of the proxy.
3030
*/
31-
function getProxyImplementation(IGraphProxy _proxy) public view returns (address) {
31+
function getProxyImplementation(IGraphProxy _proxy) external view returns (address) {
3232
// We need to manually run the static call since the getter cannot be flagged as view
3333
// bytes4(keccak256("implementation()")) == 0x5c60da1b
3434
(bool success, bytes memory returndata) = address(_proxy).staticcall(hex"5c60da1b");
@@ -42,7 +42,7 @@ contract GraphProxyAdmin is Governed {
4242
* @param _proxy Address of the proxy for which to get the pending implementation.
4343
* @return The address of the pending implementation of the proxy.
4444
*/
45-
function getProxyPendingImplementation(IGraphProxy _proxy) public view returns (address) {
45+
function getProxyPendingImplementation(IGraphProxy _proxy) external view returns (address) {
4646
// We need to manually run the static call since the getter cannot be flagged as view
4747
// bytes4(keccak256("pendingImplementation()")) == 0x396f7b23
4848
(bool success, bytes memory returndata) = address(_proxy).staticcall(hex"396f7b23");
@@ -55,7 +55,7 @@ contract GraphProxyAdmin is Governed {
5555
* @param _proxy Address of the proxy for which to get the admin.
5656
* @return The address of the current admin of the proxy.
5757
*/
58-
function getProxyAdmin(IGraphProxy _proxy) public view returns (address) {
58+
function getProxyAdmin(IGraphProxy _proxy) external view returns (address) {
5959
// We need to manually run the static call since the getter cannot be flagged as view
6060
// bytes4(keccak256("admin()")) == 0xf851a440
6161
(bool success, bytes memory returndata) = address(_proxy).staticcall(hex"f851a440");
@@ -68,7 +68,7 @@ contract GraphProxyAdmin is Governed {
6868
* @param _proxy Proxy to change admin.
6969
* @param _newAdmin Address to transfer proxy administration to.
7070
*/
71-
function changeProxyAdmin(IGraphProxy _proxy, address _newAdmin) public onlyGovernor {
71+
function changeProxyAdmin(IGraphProxy _proxy, address _newAdmin) external onlyGovernor {
7272
_proxy.setAdmin(_newAdmin);
7373
}
7474

@@ -77,7 +77,7 @@ contract GraphProxyAdmin is Governed {
7777
* @param _proxy Proxy to be upgraded.
7878
* @param _implementation the address of the Implementation.
7979
*/
80-
function upgrade(IGraphProxy _proxy, address _implementation) public onlyGovernor {
80+
function upgrade(IGraphProxy _proxy, address _implementation) external onlyGovernor {
8181
_proxy.upgradeTo(_implementation);
8282
}
8383

@@ -86,7 +86,10 @@ contract GraphProxyAdmin is Governed {
8686
* @param _implementation Address of the implementation accepting the proxy.
8787
* @param _proxy Address of the proxy being accepted.
8888
*/
89-
function acceptProxy(GraphUpgradeable _implementation, IGraphProxy _proxy) public onlyGovernor {
89+
function acceptProxy(GraphUpgradeable _implementation, IGraphProxy _proxy)
90+
external
91+
onlyGovernor
92+
{
9093
_implementation.acceptProxy(_proxy);
9194
}
9295

0 commit comments

Comments
 (0)