fix: use underscore for private variables (C4 QA)

Author: pcarranzav

contracts/governance/Controller.sol

@@ -14,7 +14,7 @@ import "./Pausable.sol";
  */
 contract Controller is Governed, Pausable, IController {
     /// @dev Track contract ids to contract proxy address
-    mapping(bytes32 => address) private registry;
+    mapping(bytes32 => address) private _registry;
 
     /// Emitted when the proxy address for a protocol contract has been set
     event SetContractProxy(bytes32 indexed id, address contractAddress);
@@ -59,7 +59,7 @@ contract Controller is Governed, Pausable, IController {
         onlyGovernor
     {
         require(_contractAddress != address(0), "Contract address must be set");
-        registry[_id] = _contractAddress;
+        _registry[_id] = _contractAddress;
         emit SetContractProxy(_id, _contractAddress);
     }
 
@@ -68,7 +68,7 @@ contract Controller is Governed, Pausable, IController {
      * @param _id Contract id (keccak256 hash of contract name)
      */
     function unsetContractProxy(bytes32 _id) external override onlyGovernor {
-        registry[_id] = address(0);
+        _registry[_id] = address(0);
         emit SetContractProxy(_id, address(0));
     }
 
@@ -78,7 +78,7 @@ contract Controller is Governed, Pausable, IController {
      * @return Address of the proxy contract for the provided id
      */
     function getContractProxy(bytes32 _id) public view override returns (address) {
-        return registry[_id];
+        return _registry[_id];
     }
 
     /**
@@ -88,7 +88,7 @@ contract Controller is Governed, Pausable, IController {
      */
     function updateController(bytes32 _id, address _controller) external override onlyGovernor {
         require(_controller != address(0), "Controller must be set");
-        return IManaged(registry[_id]).setController(_controller);
+        return IManaged(_registry[_id]).setController(_controller);
     }
 
     // -- Pausing --

contracts/governance/Managed.sol

@@ -28,7 +28,7 @@ contract Managed is IManaged {
     /// Controller that contract is registered with
     IController public controller;
     /// @dev Cache for the addresses of the contracts retrieved from the controller
-    mapping(bytes32 => address) private addressCache;
+    mapping(bytes32 => address) private _addressCache;
     /// @dev Gap for future storage variables
     uint256[10] private __gap;
 
@@ -195,7 +195,7 @@ contract Managed is IManaged {
      * @return Address of the contract
      */
     function _resolveContract(bytes32 _nameHash) internal view returns (address) {
-        address contractAddress = addressCache[_nameHash];
+        address contractAddress = _addressCache[_nameHash];
         if (contractAddress == address(0)) {
             contractAddress = controller.getContractProxy(_nameHash);
         }
@@ -209,8 +209,8 @@ contract Managed is IManaged {
     function _syncContract(string memory _name) internal {
         bytes32 nameHash = keccak256(abi.encodePacked(_name));
         address contractAddress = controller.getContractProxy(nameHash);
-        if (addressCache[nameHash] != contractAddress) {
-            addressCache[nameHash] = contractAddress;
+        if (_addressCache[nameHash] != contractAddress) {
+            _addressCache[nameHash] = contractAddress;
             emit ContractSynced(nameHash, contractAddress);
         }
     }