fix: avoid variable shadowing (C4 QA)

Author: pcarranzav

contracts/governance/Controller.sol

@@ -94,17 +94,19 @@ contract Controller is Governed, Pausable, IController {
     /**
      * @notice Change the partial paused state of the contract
      * Partial pause is intended as a partial pause of the protocol
+     * @param _toPause True if the contracts should be (partially) paused, false otherwise
      */
-    function setPartialPaused(bool _partialPaused) external override onlyGovernorOrGuardian {
-        _setPartialPaused(_partialPaused);
+    function setPartialPaused(bool _toPause) external override onlyGovernorOrGuardian {
+        _setPartialPaused(_toPause);
     }
 
     /**
      * @notice Change the paused state of the contract
      * Full pause most of protocol functions
+     * @param _toPause True if the contracts should be paused, false otherwise
      */
-    function setPaused(bool _paused) external override onlyGovernorOrGuardian {
-        _setPaused(_paused);
+    function setPaused(bool _toPause) external override onlyGovernorOrGuardian {
+        _setPaused(_toPause);
     }
 
     /**

contracts/upgrades/GraphProxy.sol

@@ -19,7 +19,7 @@ contract GraphProxy is GraphProxyStorage {
      * the sender is the admin.
      */
     modifier ifAdmin() {
-        if (msg.sender == _admin()) {
+        if (msg.sender == _getAdmin()) {
             _;
         } else {
             _fallback();
@@ -31,7 +31,7 @@ contract GraphProxy is GraphProxyStorage {
      * the sender is the admin or pending implementation.
      */
     modifier ifAdminOrPendingImpl() {
-        if (msg.sender == _admin() || msg.sender == _pendingImplementation()) {
+        if (msg.sender == _getAdmin() || msg.sender == _getPendingImplementation()) {
             _;
         } else {
             _fallback();
@@ -67,7 +67,7 @@ contract GraphProxy is GraphProxyStorage {
      * `0xb53127684a568b3173ae13b9f8a6016e243e63b6e8ee1178d6a717850b5d6103`
      */
     function admin() external ifAdminOrPendingImpl returns (address) {
-        return _admin();
+        return _getAdmin();
     }
 
     /**
@@ -80,7 +80,7 @@ contract GraphProxy is GraphProxyStorage {
      * `0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc`
      */
     function implementation() external ifAdminOrPendingImpl returns (address) {
-        return _implementation();
+        return _getImplementation();
     }
 
     /**
@@ -93,7 +93,7 @@ contract GraphProxy is GraphProxyStorage {
      * `0x9e5eddc59e0b171f57125ab86bee043d9128098c3a6b9adb4f2e86333c2f6f8c`
      */
     function pendingImplementation() external ifAdminOrPendingImpl returns (address) {
-        return _pendingImplementation();
+        return _getPendingImplementation();
     }
 
     /**
@@ -129,15 +129,15 @@ contract GraphProxy is GraphProxyStorage {
     function acceptUpgradeAndCall(bytes calldata data) external ifAdminOrPendingImpl {
         _acceptUpgrade();
         // solhint-disable-next-line avoid-low-level-calls
-        (bool success, ) = _implementation().delegatecall(data);
+        (bool success, ) = _getImplementation().delegatecall(data);
         require(success);
     }
 
     /**
      * @dev Admin function for new implementation to accept its role as implementation.
      */
     function _acceptUpgrade() internal {
-        address _pendingImplementation = _pendingImplementation();
+        address _pendingImplementation = _getPendingImplementation();
         require(Address.isContract(_pendingImplementation), "Impl must be a contract");
         require(_pendingImplementation != address(0), "Impl cannot be zero address");
         require(msg.sender == _pendingImplementation, "Only pending implementation");
@@ -152,7 +152,7 @@ contract GraphProxy is GraphProxyStorage {
      * external caller.
      */
     function _fallback() internal {
-        require(msg.sender != _admin(), "Cannot fallback to proxy target");
+        require(msg.sender != _getAdmin(), "Cannot fallback to proxy target");
 
         assembly {
             // (a) get free memory pointer

contracts/upgrades/GraphProxyStorage.sol

@@ -59,14 +59,14 @@ contract GraphProxyStorage {
      * @dev Modifier to check whether the `msg.sender` is the admin.
      */
     modifier onlyAdmin() {
-        require(msg.sender == _admin(), "Caller must be admin");
+        require(msg.sender == _getAdmin(), "Caller must be admin");
         _;
     }
 
     /**
      * @return adm The admin slot.
      */
-    function _admin() internal view returns (address adm) {
+    function _getAdmin() internal view returns (address adm) {
         bytes32 slot = ADMIN_SLOT;
         assembly {
             adm := sload(slot)
@@ -83,14 +83,14 @@ contract GraphProxyStorage {
             sstore(slot, _newAdmin)
         }
 
-        emit AdminUpdated(_admin(), _newAdmin);
+        emit AdminUpdated(_getAdmin(), _newAdmin);
     }
 
     /**
      * @dev Returns the current implementation.
      * @return impl Address of the current implementation
      */
-    function _implementation() internal view returns (address impl) {
+    function _getImplementation() internal view returns (address impl) {
         bytes32 slot = IMPLEMENTATION_SLOT;
         assembly {
             impl := sload(slot)
@@ -101,7 +101,7 @@ contract GraphProxyStorage {
      * @dev Returns the current pending implementation.
      * @return impl Address of the current pending implementation
      */
-    function _pendingImplementation() internal view returns (address impl) {
+    function _getPendingImplementation() internal view returns (address impl) {
         bytes32 slot = PENDING_IMPLEMENTATION_SLOT;
         assembly {
             impl := sload(slot)
@@ -113,7 +113,7 @@ contract GraphProxyStorage {
      * @param _newImplementation Address of the new implementation
      */
     function _setImplementation(address _newImplementation) internal {
-        address oldImplementation = _implementation();
+        address oldImplementation = _getImplementation();
 
         bytes32 slot = IMPLEMENTATION_SLOT;
         assembly {
@@ -128,7 +128,7 @@ contract GraphProxyStorage {
      * @param _newImplementation Address of the new pending implementation
      */
     function _setPendingImplementation(address _newImplementation) internal {
-        address oldPendingImplementation = _pendingImplementation();
+        address oldPendingImplementation = _getPendingImplementation();
 
         bytes32 slot = PENDING_IMPLEMENTATION_SLOT;
         assembly {