Remove useless AttributeBag::getNames()

Author: clue

lib/Fhaculty/Graph/Attribute/AttributeBag.php

@@ -24,11 +24,4 @@ public function setAttributes(array $attributes);
      * @return array
      */
     public function getAttributes();
-
-    /**
-     * get an array of the names of all existing attributes
-     *
-     * @return string[]
-     */
-    public function getNames();
 }

lib/Fhaculty/Graph/Attribute/AttributeBagContainer.php

@@ -30,11 +30,6 @@ public function setAttributes(array $attributes)
         return $this;
     }
 
-    public function getNames()
-    {
-        return array_keys($this->attributes);
-    }
-
     public function getAttributeBag()
     {
         return $this;

lib/Fhaculty/Graph/Attribute/AttributeBagNamespaced.php

@@ -50,20 +50,6 @@ public function setAttributes(array $attributes)
         }
     }
 
-    public function getNames()
-    {
-        $names = array();
-        $len = strlen($this->prefix);
-
-        foreach ($this->bag->getAttributes() as $name => $value) {
-            if (strpos($name, $this->prefix) === 0) {
-                $names []= substr($name, $len);
-            }
-        }
-
-        return $names;
-    }
-
     public function getAttributeBag()
     {
         return $this;

lib/Fhaculty/Graph/Attribute/AttributeBagReference.php

@@ -35,11 +35,6 @@ public function setAttributes(array $attributes)
         return $this;
     }
 
-    public function getNames()
-    {
-        return array_keys($this->attributes);
-    }
-
     public function getAttributeBag()
     {
         return $this;

tests/Fhaculty/Graph/Attribute/AttributeBagContainerTest.php

@@ -10,7 +10,6 @@ public function testEmpty()
 
         $this->assertNull($bag->getAttribute('unknown'));
         $this->assertEquals(array(), $bag->getAttributes());
-        $this->assertEquals(array(), $bag->getNames());
 
         $this->assertSame($bag, $bag->getAttributeBag());
     }
@@ -24,7 +23,7 @@ public function testSome()
 
         $this->assertSame(true, $bag->getAttribute('true'));
         $this->assertSame(2, $bag->getAttribute('two'));
-        $this->assertEquals(array('true', 'two'), $bag->getNames());
+        $this->assertEquals(array('true' => true, 'two' => 2), $bag->getAttributes());
 
         $bag->setAttribute('float', '1.2');
         $bag->setAttributes(array('two' => 'two', 'three' => 3));

tests/Fhaculty/Graph/Attribute/AttributeBagNamespacedTest.php

@@ -25,8 +25,7 @@ public function testBagContainer()
 
         $bag->setAttributes(array('d' => 'd', 'e' => 'e'));
 
-        $this->assertEquals(array('d', 'e'), $bag->getNames());
-        $this->assertEquals(array('a.b', 'test.d', 'test.e'), $container->getNames());
+        $this->assertEquals(array('a.b' => 'c', 'test.d' => 'd', 'test.e' => 'e'), $container->getAttributes());
     }
 
     /**
@@ -48,7 +47,6 @@ public function testReadableEntities(AttributeAware $entity)
         $this->assertNull($bag->getAttribute('test.d'));
 
         $this->assertEquals(array('d' => 'e'), $bag->getAttributes());
-        $this->assertEquals(array('d'), $bag->getNames());
     }
 
     public function provideNamespacable()

tests/Fhaculty/Graph/Attribute/AttributeBagReferenceTest.php

@@ -12,7 +12,6 @@ public function testEmpty()
 
         $this->assertNull($bag->getAttribute('unknown'));
         $this->assertEquals(array(), $bag->getAttributes());
-        $this->assertEquals(array(), $bag->getNames());
 
         $this->assertSame($bag, $bag->getAttributeBag());
     }
@@ -28,7 +27,7 @@ public function testSome()
 
         $this->assertSame(true, $bag->getAttribute('true'));
         $this->assertSame(2, $bag->getAttribute('two'));
-        $this->assertEquals(array('true', 'two'), $bag->getNames());
+        $this->assertEquals(array('true' => true, 'two' => 2), $bag->getAttributes());
 
         $bag->setAttribute('float', '1.2');
         $bag->setAttributes(array('two' => 'two', 'three' => 3));