Skip to content

Commit e9009e4

Browse files
committed
Update firmware version with TempStick firmware. TempStick API does not deterministically return a X.Y.Z version and instead shows XYZ so it will display as XYZ.0 in Homebridge.
1 parent a9fe716 commit e9009e4

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/platformAccessory.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ export class TempStickAccessory {
5151
// set accessory information
5252
this.accessory.getService(this.platform.Service.AccessoryInformation)!
5353
.setCharacteristic(this.platform.Characteristic.Manufacturer, 'Ideal Sciences, Inc.')
54-
// TODO verify type / version equivalent to model
55-
.setCharacteristic(this.platform.Characteristic.Model,
56-
'TempStick-' + accessory.context.device.type + '-' + accessory.context.device.version)
57-
.setCharacteristic(this.platform.Characteristic.SerialNumber, accessory.context.device.sensor_id);
54+
.setCharacteristic(this.platform.Characteristic.Model, 'TempStick-' + accessory.context.device.type)
55+
.setCharacteristic(this.platform.Characteristic.SerialNumber, accessory.context.device.sensor_id)
56+
// Firmware version in API is XXXX, in app X.X.XX. Unable to deterministically parse major/minor/patch
57+
.setCharacteristic(this.platform.Characteristic.FirmwareRevision, accessory.context.device.version);
5858

5959
// initialize sensorStates from the constructor accessory device
6060
this.sensorStates = this.accessory.context.device;

src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
export interface Sensor {
2-
version: string;
2+
version: string; // Firmware version XXXX -> X.X.XX
33
sensor_id: string;
44
sensor_name: string;
55
sensor_mac_addr: string;

0 commit comments

Comments
 (0)