Requests latest readings based on send_interval, next_checkin, and wifi_connect_time

gorhack · gorhack · commit 587d9f3cbb17 · 2024-07-23T21:13:55.000-04:00
Fixes:
- Correctly logs detached probe
- Names probe based on probe-type
- Add config delay if `wifi_connect_time` is not long enough for sensor to update.
diff --git a/README.md b/README.md
@@ -2,207 +2,38 @@
 
 <img src="https://github.com/homebridge/branding/raw/latest/logos/homebridge-wordmark-logo-vertical.png" width="150">
 
+
+<p align="center">
+<a href="https://www.npmjs.com/package/homebridge-tempstick"><img title="npm version" src="https://badgen.net/npm/v/homebridge-tempstick?label=stable"></a>
+<a href="https://www.npmjs.com/package/homebridge-tempstick"><img title="npm downloads" src="https://badgen.net/npm/dt/homebridge-tempstick"></a>
+<a href="https://github.com/gorhack/tempstick/actions/workflows/build.yml"><img title="Node Build" src="https://github.com/gorhack/tempstick/actions/workflows/build.yml/badge.svg"></a>
 </p>
 
 # Ideal Sciences Temp Stick Homebridge Plugin
 
-This is an unnofficial plugin to use your [Temp Stick](https://tempstick.com/) sensor with Homebridge.
+### This is an unofficial plugin to use your [Temp Stick](https://tempstick.com/) sensor with [Homebridge](https://homebridge.io/).
 
 You will need your API key, provided in your [account](https://mytempstick.com/account#developers) settings. This plugin relies on the API provided by Temp
 Stick and is dependent on its uptime to retrieve your latest sensors and readings. 
 
+Once loaded, this plugin will display all Temp Stick sensors' ambient temperature and humidity. If you are using a
+thermocouple probe, it will also display the probe's temperature. This plugin updates the sensor data at roughly the
+same interval set within your account's `Sensor Settings` (once every 15 minutes to 24 hours). Temp Stick, nor this
+plugin, will display live Temp Stick readings as the sensor is only active during its `next_checkin`.
+
+If you change any settings or names in your Temp Stick account you may have to reload the plugin to see those changes
+reflected and receive timely results.
+
 ### Development Roadmap:
 - [x] Discover all sensors and probes
 - [x] Ambient temperature, ambient humidity, and probe temperature
 - [x] Handle API errors gracefully
-- [ ] Use offsets (`probe_temp_offset`, `humidity_offset`, `temp_offset`) for calibrated sensors
-- [ ] Request latest readings based on `send_interval` and `next_checkin`
+- [x] Use offsets (`probe_temp_offset`, `humidity_offset`, `temp_offset`) for calibrated sensors
+  - `last_tcTemp`, `last_humidity`, and `last_temp` include any user-set offset
+- [x] Request latest readings based on `send_interval` and `next_checkin`
 - [ ] Homebridge [verified](https://github.com/homebridge/verified)
-- [ ] Request updated documentation in [API](https://tempstickapi.com/docs/) for undocumented parameters
+- [x] Request updated documentation in [API](https://tempstickapi.com/docs/) for undocumented parameters
 (`last_tcTemp` and `groups` for example)
-
-<span align="center">
-
-# Homebridge Platform Plugin Template
-
-</span>
-
-This is a template Homebridge dynamic platform plugin and can be used as a base to help you get started developing your own plugin.
-
-This template should be used in conjunction with the [developer documentation](https://developers.homebridge.io/). A full list of all supported service types, and their characteristics is available on this site.
-
-### Clone As Template
-
-Click the link below to create a new GitHub Repository using this template, or click the *Use This Template* button above.
-
-<span align="center">
-
-### [Create New Repository From Template](https://github.com/homebridge/homebridge-plugin-template/generate)
-
-</span>
-
-### Setup Development Environment
-
-To develop Homebridge plugins you must have Node.js 18 or later installed, and a modern code editor such as [VS Code](https://code.visualstudio.com/). This plugin template uses [TypeScript](https://www.typescriptlang.org/) to make development easier and comes with pre-configured settings for [VS Code](https://code.visualstudio.com/) and ESLint. If you are using VS Code install these extensions:
-
-- [ESLint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
-
-### Install Development Dependencies
-
-Using a terminal, navigate to the project folder and run this command to install the development dependencies:
-
-```shell
-npm install
-```
-
-### Update package.json
-
-Open the [`package.json`](./package.json) and change the following attributes:
-
-- `name` - this should be prefixed with `homebridge-` or `@username/homebridge-`, is case-sensitive, and contains no spaces nor special characters apart from a dash `-`
-- `displayName` - this is the "nice" name displayed in the Homebridge UI
-- `repository.url` - Link to your GitHub repo
-- `bugs.url` - Link to your GitHub repo issues page
-
-When you are ready to publish the plugin you should set `private` to false, or remove the attribute entirely.
-
-### Update Plugin Defaults
-
-Open the [`src/settings.ts`](./src/settings.ts) file and change the default values:
-
-- `PLATFORM_NAME` - Set this to be the name of your platform. This is the name of the platform that users will use to register the plugin in the Homebridge `config.json`.
-- `PLUGIN_NAME` - Set this to be the same name you set in the [`package.json`](./package.json) file. 
-
-Open the [`config.schema.json`](./config.schema.json) file and change the following attribute:
-
-- `pluginAlias` - set this to match the `PLATFORM_NAME` you defined in the previous step.
-
-### Build Plugin
-
-TypeScript needs to be compiled into JavaScript before it can run. The following command will compile the contents of your [`src`](./src) directory and put the resulting code into the `dist` folder.
-
-```shell
-npm run build
-```
-
-### Link To Homebridge
-
-Run this command so your global installation of Homebridge can discover the plugin in your development environment:
-
-```shell
-npm link
-```
-
-You can now start Homebridge, use the `-D` flag, so you can see debug log messages in your plugin:
-
-```shell
-homebridge -D
-```
-
-### Watch For Changes and Build Automatically
-
-If you want to have your code compile automatically as you make changes, and restart Homebridge automatically between changes, you first need to add your plugin as a platform in `~/.homebridge/config.json`:
-```
-{
-...
-    "platforms": [
-        {
-            "name": "Config",
-            "port": 8581,
-            "platform": "config"
-        },
-        {
-            "name": "<PLUGIN_NAME>",
-            //... any other options, as listed in config.schema.json ...
-            "platform": "<PLATFORM_NAME>"
-        }
-    ]
-}
-```
-
-and then you can run:
-
-```shell
-npm run watch
-```
-
-This will launch an instance of Homebridge in debug mode which will restart every time you make a change to the source code. It will load the config stored in the default location under `~/.homebridge`. You may need to stop other running instances of Homebridge while using this command to prevent conflicts. You can adjust the Homebridge startup command in the [`nodemon.json`](./nodemon.json) file.
-
-### Customise Plugin
-
-You can now start customising the plugin template to suit your requirements.
-
-- [`src/platform.ts`](./src/platform.ts) - this is where your device setup and discovery should go.
-- [`src/platformAccessory.ts`](./src/platformAccessory.ts) - this is where your accessory control logic should go, you can rename or create multiple instances of this file for each accessory type you need to implement as part of your platform plugin. You can refer to the [developer documentation](https://developers.homebridge.io/) to see what characteristics you need to implement for each service type.
-- [`config.schema.json`](./config.schema.json) - update the config schema to match the config you expect from the user. See the [Plugin Config Schema Documentation](https://developers.homebridge.io/#/config-schema).
-
-### Versioning Your Plugin
-
-Given a version number `MAJOR`.`MINOR`.`PATCH`, such as `1.4.3`, increment the:
-
-1. **MAJOR** version when you make breaking changes to your plugin,
-2. **MINOR** version when you add functionality in a backwards compatible manner, and
-3. **PATCH** version when you make backwards compatible bug fixes.
-
-You can use the `npm version` command to help you with this:
-
-```shell
-# major update / breaking changes
-npm version major
-
-# minor update / new features
-npm version update
-
-# patch / bugfixes
-npm version patch
-```
-
-### Publish Package
-
-When you are ready to publish your plugin to [npm](https://www.npmjs.com/), make sure you have removed the `private` attribute from the [`package.json`](./package.json) file then run:
-
-```shell
-npm publish
-```
-
-If you are publishing a scoped plugin, i.e. `@username/homebridge-xxx` you will need to add `--access=public` to command the first time you publish.
-
-#### Publishing Beta Versions
-
-You can publish *beta* versions of your plugin for other users to test before you release it to everyone.
-
-```shell
-# create a new pre-release version (eg. 2.1.0-beta.1)
-npm version prepatch --preid beta
-
-# publish to @beta
-npm publish --tag=beta
-```
-
-Users can then install the  *beta* version by appending `@beta` to the install command, for example:
-
-```shell
-sudo npm install -g homebridge-example-plugin@beta
-```
-
-### Best Practices
-Consider creating your plugin with the [Homebridge Verified](https://github.com/homebridge/verified) criteria in mind. This will help you to create a plugin that is easy to use and works well with Homebridge.
-You can then submit your plugin to the Homebridge Verified list for review.
-The most up-to-date criteria can be found [here](https://github.com/homebridge/verified#requirements).
-For reference, the current criteria are:
-
-- The plugin must successfully install.
-- The plugin must implement the [Homebridge Plugin Settings GUI](https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Plugin-Settings-GUI).
-- The plugin must not start unless it is configured.
-- The plugin must not execute post-install scripts that modify the users' system in any way.
-- The plugin must not contain any analytics or calls that enable you to track the user.
-- The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
-- The plugin must be published to npm and the source code available on GitHub.
-  - A GitHub release - with patch notes - should be created for every new version of your plugin.
-- The plugin must run on all [supported LTS versions of Node.js](https://github.com/homebridge/homebridge/wiki/How-To-Update-Node.js), at the time of writing this is Node.js v16 and v18.
-- The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
-- If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
-
-### Useful Links
-Note these links are here for help but are not supported/verified by the Homebridge team
-- [Custom Characteristics](https://github.com/homebridge/homebridge-plugin-template/issues/20)
+  - Response: "...you don't need to worry about these values as they don't have a direct impact
+    on the data readings"
+- [ ] User config `groups` of sensors instead of retrieving all sensors
diff --git a/config.schema.json b/config.schema.json
@@ -17,6 +17,14 @@
         "required": true,
         "pattern": "^[A-Za-z0-9]*$",
         "description": "Found at https://mytempstick.com/account#developers"
+      },
+      "delay": {
+        "title": "Delay (in seconds)",
+        "type": "number",
+        "required": false,
+        "placeholder": "5",
+        "pattern": "^[0-9]*$",
+        "description": "Add an additional delay if your Homekit readings are behind your Temp Stick readings."
       }
     }
   }
diff --git a/package.json b/package.json
@@ -3,6 +3,7 @@
   "name": "homebridge-tempstick",
   "version": "1.0.3",
   "description": "Unofficial Ideal Sciences TempStick homebridge plugin.",
+  "homepage": "https://github.com/gorhack/tempstick",
   "license": "Apache-2.0",
   "type": "module",
   "repository": {
@@ -19,12 +20,15 @@
   "main": "dist/index.js",
   "scripts": {
     "lint": "eslint src/**/*.ts --max-warnings=0",
-    "watch": "npm run build && sudo hb-service unlink && sudo hb-service link && nodemon",
+    "watch": "npm run build && sudo hb-service unlink || true && sudo hb-service link && nodemon",
     "build": "rimraf ./dist && tsc",
     "prepublishOnly": "npm run lint && npm run build"
   },
   "keywords": [
-    "homebridge-plugin"
+    "homebridge-plugin",
+    "temp stick",
+    "tempstick",
+    "ideal sciences"
   ],
   "devDependencies": {
     "@types/node": "^20.14.10",
diff --git a/src/platform.ts b/src/platform.ts
@@ -63,6 +63,10 @@ export class TempStickHomebridgePlatform implements DynamicPlatformPlugin {
    * must not be registered again to prevent "duplicate UUID" errors.
    */
   discoverDevices() {
+    if (!this.config.apiKey) {
+      this.log.error('Must have an API key configured in the plugin configuration.');
+      return;
+    }
     this.log.debug('Discovering devices with apikey ' + this.config.apiKey);
     (async () => {
       try {
@@ -111,12 +115,12 @@ export class TempStickHomebridgePlatform implements DynamicPlatformPlugin {
             this.api.registerPlatformAccessories(PLUGIN_NAME, PLATFORM_NAME, [accessory]);
           }
 
-          // TODO use calibrated settings: probe_temp_offset, humidity_offset, temp_offset
           this.log.info(`Initialized accessory ${sensor.sensor_name}. ` +
                 `It is ${parseInt(sensor.offline) ? 'offline' : 'online'}. ` +
                 `The latest ambient temp was ${sensor.last_temp}°C, ` +
                 `ambient humidity of ${sensor.last_humidity}%, ` +
-                `${sensor.last_tcTemp ? `probe temp of ${sensor.last_tcTemp}°C ` : ''}` +
+                `${sensor.last_tcTemp && sensor.last_tcTemp !== 'n' && sensor.TC_TYPE ?
+                  `${sensor.TC_TYPE}-probe temp of ${sensor.last_tcTemp}°C, ` : ''}` +
                 `and battery level at ${sensor.battery_pct}%`);
         });
 
diff --git a/src/platformAccessory.ts b/src/platformAccessory.ts
diff --git a/src/utils.ts b/src/utils.ts

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,14 @@`
`17`	`17`	`"required": true,`
`18`	`18`	`"pattern": "^[A-Za-z0-9]*$",`
`19`	`19`	`"description": "Found at https://mytempstick.com/account#developers"`
	`20`	`+ },`
	`21`	`+ "delay": {`
	`22`	`+ "title": "Delay (in seconds)",`
	`23`	`+ "type": "number",`
	`24`	`+ "required": false,`
	`25`	`+ "placeholder": "5",`
	`26`	`+ "pattern": "^[0-9]*$",`
	`27`	`+ "description": "Add an additional delay if your Homekit readings are behind your Temp Stick readings."`
`20`	`28`	`}`
`21`	`29`	`}`
`22`	`30`	`}`