Skip to content

Commit 5271cbc

Browse files
Merge pull request #196 from alrs/clientconfig-errs
openstack/clientconfig: fix dropped errors
2 parents d9fca82 + 4f57841 commit 5271cbc

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

openstack/clientconfig/requests.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ func GetCloudFromYAML(opts *ClientOpts) (*Cloud, error) {
332332

333333
cloud.Interface = ""
334334

335-
return cloud, nil
335+
return cloud, err
336336
}
337337

338338
// AuthOptions creates a gophercloud.AuthOptions structure with the

openstack/clientconfig/utils.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ func mergeClouds(override, cloud interface{}) (*Cloud, error) {
4646
var mergedCloud Cloud
4747
mergedInterface := mergeInterfaces(overrideInterface, cloudInterface)
4848
mergedJson, err := json.Marshal(mergedInterface)
49+
if err != nil {
50+
return nil, err
51+
}
4952
err = json.Unmarshal(mergedJson, &mergedCloud)
5053
if err != nil {
5154
return nil, err

0 commit comments

Comments
 (0)