Skip to content

Commit b508b14

Browse files
committed
Fix formatting issue with interface pointer.
1 parent 73178e2 commit b508b14

2 files changed

Lines changed: 2 additions & 24 deletions

File tree

NtApiDotNet/Ndr/IdlNdrFormatterInternal.cs

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -572,21 +572,6 @@ private void FormatEncapsulatedUnion(NdrStringBuilder builder, NdrUnionTypeRefer
572572
builder.AppendLine("};");
573573
}
574574

575-
private string FormatLineComment(string comment, params object[] args)
576-
{
577-
if (_remove_comments)
578-
{
579-
return string.Empty;
580-
}
581-
582-
return $"// {(args.Length > 0 ? string.Format(comment, args) : comment)}";
583-
}
584-
585-
private void FormatProcedure(NdrStringBuilder builder, NdrProcedureDefinition procedure)
586-
{
587-
FormatProcedure(builder, procedure, false);
588-
}
589-
590575
private string FormatType(NdrBaseTypeReference base_type)
591576
{
592577
if (_enable_typedefs)
@@ -597,13 +582,6 @@ private string FormatType(NdrBaseTypeReference base_type)
597582
return base_type.FormatType(this);
598583
}
599584

600-
private string FormatArrayType(NdrBaseArrayTypeReference array_type)
601-
{
602-
int element_count = array_type.ElementCount;
603-
_postfix.Push($"[{(element_count == 0 ? string.Empty : element_count.ToString())}]");
604-
return $"{FormatType(array_type.ElementType)}";
605-
}
606-
607585
private string GetPostFix()
608586
{
609587
string ret = string.Join(string.Empty, _postfix);
@@ -680,7 +658,7 @@ private void FormatComProxy(NdrStringBuilder builder, NdrComProxyDefinition type
680658
builder.AppendLine("]");
681659

682660
string base_name = IidToName(type.BaseIid);
683-
if (base_name == string.Empty)
661+
if (string.IsNullOrEmpty(base_name))
684662
{
685663
string unknown_iid = $"Unknown IID {type.BaseIid}";
686664
base_name = $"{FormatComment(unknown_iid)}IUnknown";

NtApiDotNet/Ndr/NdrPointerTypes.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ internal override string FormatType(INdrFormatterInternal formatter)
6565
if (IsConstant)
6666
{
6767
string name = formatter.IidToName(Iid);
68-
if (name != null)
68+
if (!string.IsNullOrEmpty(name))
6969
{
7070
return formatter.FormatPointer(name);
7171
}

0 commit comments

Comments
 (0)