Fix parsing of NDR Union arm types (#71)

qtc-de · web-flow · commit b3aa34c784da · 2023-09-26T10:11:35.000+01:00
When parsing NDR Union arm types, the offset_to_arm_description is
incorrectly parsed for certain values. This commit attempts to fix this.
diff --git a/NtApiDotNet/Ndr/NdrUnionTypes.cs b/NtApiDotNet/Ndr/NdrUnionTypes.cs
@@ -53,7 +53,7 @@ internal NdrUnionArm(NdrParseContext context, BinaryReader reader)
         internal static NdrBaseTypeReference ReadArmType(NdrParseContext context, BinaryReader reader)
         {
             ushort type = reader.ReadUInt16();
-            if ((type & 0x8F00) == 0x8000)
+            if ((type & 0xFF00) == 0x8000)
             {
                 return new NdrSimpleTypeReference((NdrFormatCharacter)(type & 0xFF));
             }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ internal NdrUnionArm(NdrParseContext context, BinaryReader reader)`
`53`	`53`	`internal static NdrBaseTypeReference ReadArmType(NdrParseContext context, BinaryReader reader)`
`54`	`54`	`{`
`55`	`55`	`ushort type = reader.ReadUInt16();`
`56`		`- if ((type & 0x8F00) == 0x8000)`
	`56`	`+ if ((type & 0xFF00) == 0x8000)`
`57`	`57`	`{`
`58`	`58`	`return new NdrSimpleTypeReference((NdrFormatCharacter)(type & 0xFF));`
`59`	`59`	`}`