Fix for ParseEnvironmentBlock - switching to ordinal search for end_index (#69)

lowleveldesign · web-flow · commit ae0ab679e4d4 · 2023-02-24T00:17:46.000Z
diff --git a/NtApiDotNet/NtProcessEnvironmentVariable.cs b/NtApiDotNet/NtProcessEnvironmentVariable.cs
@@ -54,7 +54,7 @@ internal NtProcessEnvironmentVariable(string value)
         internal static IEnumerable<NtProcessEnvironmentVariable> ParseEnvironmentBlock(byte[] environment)
         {
             string env_str = Encoding.Unicode.GetString(environment);
-            int end_index = env_str.IndexOf("\0\0");
+            int end_index = env_str.IndexOf("\0\0", StringComparison.Ordinal);
             if (end_index >= 0)
             {
                 env_str = env_str.Substring(0, end_index);

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ internal NtProcessEnvironmentVariable(string value)`
`54`	`54`	`internal static IEnumerable<NtProcessEnvironmentVariable> ParseEnvironmentBlock(byte[] environment)`
`55`	`55`	`{`
`56`	`56`	`string env_str = Encoding.Unicode.GetString(environment);`
`57`		`- int end_index = env_str.IndexOf("\0\0");`
	`57`	`+ int end_index = env_str.IndexOf("\0\0", StringComparison.Ordinal);`
`58`	`58`	`if (end_index >= 0)`
`59`	`59`	`{`
`60`	`60`	`env_str = env_str.Substring(0, end_index);`