Added OwnsCredentials property to manage the scope of credentials.

Author: tyranid

NtApiDotNet/Win32/Rpc/Transport/RpcTransportSecurity.cs

@@ -203,12 +203,9 @@ internal IClientAuthenticationContext CreateClientContext()
                     throw new ArgumentException($"Unsupported authentication level {AuthenticationLevel}");
             }
 
-            using (var creds = CredentialHandle.Create(GetAuthPackageName(),
-                    SecPkgCredFlags.Outbound, Credentials))
-            {
-                return new ClientAuthenticationContext(creds, GetContextRequestFlags(),
-                    ServicePrincipalName, SecDataRep.Native);
-            }
+            return new ClientAuthenticationContext(CredentialHandle.Create(GetAuthPackageName(),
+                SecPkgCredFlags.Outbound, Credentials), GetContextRequestFlags(),
+                    ServicePrincipalName, SecDataRep.Native) { OwnsCredentials = true };
         }
         #endregion
     }

NtApiDotNet/Win32/Security/Authentication/ClientAuthenticationContext.cs

@@ -67,6 +67,10 @@ private void Dispose(bool _)
                 SecurityNativeMethods.DeleteSecurityContext(_context);
                 _context = null;
             }
+            if (OwnsCredentials)
+            {
+                _creds?.Dispose();
+            }
         }
         #endregion
 
@@ -185,6 +189,12 @@ private void Dispose(bool _)
         /// </summary>
         public bool IsLoopback => SecurityContextUtils.GetIsLoopback(Context);
 
+        /// <summary>
+        /// Get or set whether the context owns the credentials object or not. If true
+        /// then the credentials are disposed with the context.
+        /// </summary>
+        public bool OwnsCredentials { get; set; }
+
         #endregion
 
         #region Constructors

NtApiDotNet/Win32/Security/Authentication/ServerAuthenticationContext.cs

@@ -59,13 +59,16 @@ private SecStatusCode CallAccept(List<SecurityBuffer> input_buffers, List<Securi
             return result;
         }
 
-
         private void Dispose(bool _)
         {
             if (_context != null)
             {
                 SecurityNativeMethods.DeleteSecurityContext(_context);
             }
+            if (OwnsCredentials)
+            {
+                _creds?.Dispose();
+            }
         }
 
         private string GetTargetName()
@@ -196,6 +199,12 @@ private string GetTargetName()
         /// </summary>
         public bool IsLoopback => SecurityContextUtils.GetIsLoopback(Context);
 
+        /// <summary>
+        /// Get or set whether the context owns the credentials object or not. If true
+        /// then the credentials are disposed with the context.
+        /// </summary>
+        public bool OwnsCredentials { get; set; }
+
         #endregion
 
         #region Public Methods