Fix stack overflow in parsing full embedded pointers.

tyranid · tyranid · commit 71139fb6bf1a · 2021-11-26T09:35:47.000-08:00
diff --git a/NtApiDotNet/Ndr/Marshal/NdrUnmarshalBuffer.cs b/NtApiDotNet/Ndr/Marshal/NdrUnmarshalBuffer.cs
@@ -746,7 +746,8 @@ public NdrEmbeddedPointer<T> ReadEmbeddedPointer<T>(Func<T> unmarshal_func, bool
 
             if (full_pointer)
             {
-                unmarshal_func = () => ReadFullPointer(referent, unmarshal_func);
+                Func<T> original_unmarshal_func = unmarshal_func;
+                unmarshal_func = () => ReadFullPointer(referent, original_unmarshal_func);
             }
 
             var deferred_reader = NdrEmbeddedPointer<T>.CreateDeferredReader(unmarshal_func);

Original file line number	Diff line number	Diff line change
`@@ -746,7 +746,8 @@ public NdrEmbeddedPointer<T> ReadEmbeddedPointer<T>(Func<T> unmarshal_func, bool`
`746`	`746`
`747`	`747`	`if (full_pointer)`
`748`	`748`	`{`
`749`		`- unmarshal_func = () => ReadFullPointer(referent, unmarshal_func);`
	`749`	`+ Func<T> original_unmarshal_func = unmarshal_func;`
	`750`	`+ unmarshal_func = () => ReadFullPointer(referent, original_unmarshal_func);`
`750`	`751`	`}`
`751`	`752`
`752`	`753`	`var deferred_reader = NdrEmbeddedPointer<T>.CreateDeferredReader(unmarshal_func);`