Skip to content

Commit f9cacf4

Browse files
Danylo MocherniukV8-internal LUCI CQ
authored andcommitted
[dumpling] add non-materialized option to Oracle
Until non-materialized printing is implemented for everything, we will allow it to match anything similar to <optimized_out>. Bug: 441467877 Change-Id: I681ceba56a88e66220ee00d65a7f8f4166042cd5 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/9026356 Commit-Queue: Danylo Mocherniuk <mdanylo@google.com> Reviewed-by: Michael Achenbach <machenbach@google.com>
1 parent 57da3ab commit f9cacf4

2 files changed

Lines changed: 30 additions & 2 deletions

File tree

Sources/Fuzzilli/DumplingDiffOracle/Oracle.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,9 @@ public final class DiffOracle {
133133
return false
134134
}
135135

136-
// Logic: 'self' is the Optimized frame. It is allowed to have "<optimized_out>".
136+
// Logic: 'self' is the Optimized frame. It is allowed to have "<optimized_out>" or "<non-materialized>".
137137
func isMatch(_ optValue: String, unoptValue: String) -> Bool {
138-
return optValue == "<optimized_out>" || optValue == unoptValue
138+
return optValue == "<optimized_out>" || optValue == "<non-materialized>" || optValue == unoptValue
139139
}
140140

141141
if !isMatch(self.accumulator, unoptValue: reference.accumulator) {

Tests/FuzzilliTests/DiffOracleTests.swift

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,34 @@ final class DiffOracleTests: XCTestCase {
132132
XCTAssertTrue(DiffOracle.relate(opt, with: unopt))
133133
}
134134

135+
func testNonMaterializedArgument() {
136+
let unopt = """
137+
---I
138+
b:10
139+
f:1
140+
x:0
141+
n:2
142+
m:0
143+
a0:RealVal
144+
a1:OtherVal
145+
146+
"""
147+
148+
let opt = """
149+
---I
150+
b:10
151+
f:1
152+
x:0
153+
n:2
154+
m:0
155+
a0:<non-materialized>
156+
a1:OtherVal
157+
158+
"""
159+
160+
XCTAssertTrue(DiffOracle.relate(opt, with: unopt))
161+
}
162+
135163
func testArgumentMismatch() {
136164
let unopt = """
137165
---I

0 commit comments

Comments
 (0)