Skip to content

Commit 794c0f0

Browse files
Dominik KlembaV8-internal LUCI CQ
authored andcommitted
Add new fuzzing flags for V8
This change introduces the following flags to the V8 fuzzing profile: - --maglev-as-top-tier - --maglev-non-eager-inlining - --max_maglev_inlined_bytecode_size_small=0 - --max_inlined_bytecode_size_small=0 These flags are expected to increase fuzzing coverage for edge cases in the V8 engine. While the probabilities in the code may seem high, they are conditional and depend on other flags being set. Bug: 456452258, 456451490, 456142887, 455592879 Change-Id: I486170bc27798f31ee905f2ff8e6c881a44b9265 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8736336 Commit-Queue: Dominik Klemba <tacet@google.com> Reviewed-by: Matthias Liedtke <mliedtke@google.com> Auto-Submit: Dominik Klemba <tacet@google.com> Reviewed-by: Victor Gomes <victorgomes@google.com> Reviewed-by: Darius Mercadier <dmercadier@google.com>
1 parent 59f6bd2 commit 794c0f0

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

Sources/FuzzilliCli/Profiles/V8Profile.swift

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ let v8Profile = Profile(
4141
//
4242
if probability(0.1) {
4343
args.append("--no-turbofan")
44+
if probability(0.5) {
45+
args.append("--maglev-as-top-tier")
46+
}
4447
}
4548

4649
if probability(0.1) {
@@ -91,6 +94,13 @@ let v8Profile = Profile(
9194
args.append("--maglev-future")
9295
}
9396

97+
if probability(0.2) && !args.contains("--no-maglev") {
98+
args.append("--maglev-non-eager-inlining")
99+
if probability(0.4) { // TODO: @tacet decrease this probability to max 0.2
100+
args.append("--max_maglev_inlined_bytecode_size_small=0")
101+
}
102+
}
103+
94104
if probability(0.1) {
95105
args.append("--turboshaft-typed-optimizations")
96106
}
@@ -99,6 +109,9 @@ let v8Profile = Profile(
99109
args.append("--turbolev")
100110
if probability(0.82) {
101111
args.append("--turbolev-future")
112+
if probability(0.3) { // TODO: @tacet change to 0.15
113+
args.append("--max_inlined_bytecode_size_small=0")
114+
}
102115
}
103116
}
104117

0 commit comments

Comments
 (0)