Skip to content

Commit 3e040df

Browse files
LiedtkeV8-internal LUCI CQ
authored andcommitted
[v8-sandbox] Don't alert on the JS corruption API failing
We create alerts when the logs contain ": Assertion Failed" to catch Swift assertions. We have cases where the ExplorationMutator runs into issues when running the instrumented code that contains both the instrumentation for the corrupt() call to cause in-sandbox corruption as well as the exploration mutation running and then causing one of these assert calls in JS to fail. I don't think it should be considered a critical unexpected failure when this is triggered. Change-Id: I149132d9f081df62554d2e3c543fb63f9c299b71 Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8719276 Auto-Submit: Matthias Liedtke <mliedtke@google.com> Reviewed-by: Michael Achenbach <machenbach@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com>
1 parent 771d4c8 commit 3e040df

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Sources/FuzzilliCli/Profiles/V8SandboxProfile.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ let v8SandboxProfile = Profile(
9797
9898
function assert(c) {
9999
if (!c) {
100-
throw new Error("Assertion failed!");
100+
throw new Error("Assertion in the in-sandbox-corruption API failed!");
101101
}
102102
}
103103

0 commit comments

Comments
 (0)