[wasm] Remove parameter types from wasmReassign

Bug: 445356784
Change-Id: If6049b20eb2a77ce27c04412f571af7626b4216b
Reviewed-on: https://chrome-internal-review.googlesource.com/c/v8/fuzzilli/+/8926700
Reviewed-by: Doga Yüksel <dyuksel@google.com>
Commit-Queue: Matthias Liedtke <mliedtke@google.com>

Author: Liedtke

Sources/Fuzzilli/Base/ProgramBuilder.swift

@@ -3906,8 +3906,8 @@ public class ProgramBuilder {
         }
 
         public func wasmReassign(variable: Variable, to: Variable) {
-            assert(b.type(of: variable) == b.type(of: to))
-            b.emit(WasmReassign(variableType: b.type(of: variable)), withInputs: [variable, to])
+            assert(b.type(of: to).Is(b.type(of: variable)))
+            b.emit(WasmReassign(), withInputs: [variable, to])
         }
 
         public enum wasmBlockType {

Sources/Fuzzilli/FuzzIL/Instruction.swift

@@ -1234,8 +1234,8 @@ extension Instruction: ProtobufConvertible {
             case .wasmTruncateSatf64Toi64(let op):
                 $0.wasmTruncateSatf64Toi64 = Fuzzilli_Protobuf_WasmTruncateSatf64Toi64.with { $0.isSigned = op.isSigned }
 
-           case .wasmReassign(let op):
-                $0.wasmReassign = Fuzzilli_Protobuf_WasmReassign.with { $0.variableType = ILTypeToWasmTypeEnum(op.variableType) }
+           case .wasmReassign(_):
+                $0.wasmReassign = Fuzzilli_Protobuf_WasmReassign()
             case .wasmDefineGlobal(let op):
                 $0.wasmDefineGlobal = Fuzzilli_Protobuf_WasmDefineGlobal.with {
                     $0.wasmGlobal.isMutable = op.isMutable
@@ -2369,8 +2369,8 @@ extension Instruction: ProtobufConvertible {
         case .wasmTruncateSatf64Toi64(let p):
             op = WasmTruncateSatf64Toi64(isSigned: p.isSigned)
 
-        case .wasmReassign(let p):
-            op = WasmReassign(variableType: WasmTypeEnumToILType(p.variableType))
+        case .wasmReassign(_):
+            op = WasmReassign()
         case .wasmDefineGlobal(let p):
             op = WasmDefineGlobal(wasmGlobal: convertWasmGlobal(p.wasmGlobal), isMutable: p.wasmGlobal.isMutable)
         case .wasmDefineTable(let p):

Sources/Fuzzilli/FuzzIL/WasmOperations.swift

@@ -1535,10 +1535,7 @@ final class WasmBranchTable: WasmOperation {
 final class WasmReassign: WasmOperation {
     override var opcode: Opcode { .wasmReassign(self) }
 
-    let variableType: ILType
-
-    init(variableType: ILType) {
-        self.variableType = variableType
+    init() {
         super.init(numInputs: 2, attributes: [.isNotInputMutable], requiredContext: [.wasmFunction])
     }
 }

Sources/Fuzzilli/Lifting/WasmLifter.swift

@@ -1980,7 +1980,7 @@ public class WasmLifter {
             // wasmReassign is quite special, it needs to work for variables stored in various places, e.g. local slots or even globals. As such the lifting here first needs to locate the destination variable.
             var out = Data()
 
-            var storeInstruction = Data()
+            let storeInstruction: Data
             // If the variable is a local, we load the stack slot.
             // Check for the stack location of the `to` variable.
             if let stackSlot = currentFunction!.getStackSlot(for: wasmInstruction.input(0)) {

Sources/Fuzzilli/Protobuf/operations.pb.swift

@@ -5377,20 +5377,9 @@ public struct Fuzzilli_Protobuf_WasmReassign: Sendable {
   // `Message` and `Message+*Additions` files in the SwiftProtobuf library for
   // methods supported on all messages.
 
-  public var variableType: Fuzzilli_Protobuf_WasmILType {
-    get {return _variableType ?? Fuzzilli_Protobuf_WasmILType()}
-    set {_variableType = newValue}
-  }
-  /// Returns true if `variableType` has been explicitly set.
-  public var hasVariableType: Bool {return self._variableType != nil}
-  /// Clears the value of `variableType`. Subsequent reads from it will return its default value.
-  public mutating func clearVariableType() {self._variableType = nil}
-
   public var unknownFields = SwiftProtobuf.UnknownStorage()
 
   public init() {}
-
-  fileprivate var _variableType: Fuzzilli_Protobuf_WasmILType? = nil
 }
 
 public struct Fuzzilli_Protobuf_WasmBeginIf: Sendable {
@@ -14212,33 +14201,18 @@ extension Fuzzilli_Protobuf_WasmBranchTable: SwiftProtobuf.Message, SwiftProtobu
 
 extension Fuzzilli_Protobuf_WasmReassign: SwiftProtobuf.Message, SwiftProtobuf._MessageImplementationBase, SwiftProtobuf._ProtoNameProviding {
   public static let protoMessageName: String = _protobuf_package + ".WasmReassign"
-  public static let _protobuf_nameMap = SwiftProtobuf._NameMap(bytecode: "\0\u{1}variableType\0")
+  public static let _protobuf_nameMap = SwiftProtobuf._NameMap()
 
   public mutating func decodeMessage<D: SwiftProtobuf.Decoder>(decoder: inout D) throws {
-    while let fieldNumber = try decoder.nextFieldNumber() {
-      // The use of inline closures is to circumvent an issue where the compiler
-      // allocates stack space for every case branch when no optimizations are
-      // enabled. https://github.com/apple/swift-protobuf/issues/1034
-      switch fieldNumber {
-      case 1: try { try decoder.decodeSingularMessageField(value: &self._variableType) }()
-      default: break
-      }
-    }
+    // Load everything into unknown fields
+    while try decoder.nextFieldNumber() != nil {}
   }
 
   public func traverse<V: SwiftProtobuf.Visitor>(visitor: inout V) throws {
-    // The use of inline closures is to circumvent an issue where the compiler
-    // allocates stack space for every if/case branch local when no optimizations
-    // are enabled. https://github.com/apple/swift-protobuf/issues/1034 and
-    // https://github.com/apple/swift-protobuf/issues/1182
-    try { if let v = self._variableType {
-      try visitor.visitSingularMessageField(value: v, fieldNumber: 1)
-    } }()
     try unknownFields.traverse(visitor: &visitor)
   }
 
   public static func ==(lhs: Fuzzilli_Protobuf_WasmReassign, rhs: Fuzzilli_Protobuf_WasmReassign) -> Bool {
-    if lhs._variableType != rhs._variableType {return false}
     if lhs.unknownFields != rhs.unknownFields {return false}
     return true
   }

Sources/Fuzzilli/Protobuf/operations.proto

@@ -1328,7 +1328,6 @@ message WasmBranchTable {
 }
 
 message WasmReassign {
-  WasmILType variableType = 1;
 }
 
 message WasmBeginIf {