Skip to content
This repository was archived by the owner on Mar 16, 2026. It is now read-only.

Commit 5e7dc74

Browse files
committed
adds two functions to avoid NotImplementedErrors
1 parent 0028b3f commit 5e7dc74

2 files changed

Lines changed: 22 additions & 3 deletions

File tree

noxfile.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -443,11 +443,11 @@ def compliance(session):
443443

444444
session.run(
445445
"py.test",
446-
"-n=auto",
446+
"-n=2",
447447
"-vv",
448448
f"--junitxml=compliance_{session.python}_sponge_log.xml",
449-
"--reruns=3",
450-
"--reruns-delay=60",
449+
"--reruns=0",
450+
"--reruns-delay=1",
451451
"--only-rerun=Exceeded rate limits",
452452
"--only-rerun=Already Exists",
453453
"--only-rerun=Not found",

sqlalchemy_bigquery/base.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,25 @@
6969

7070
TABLE_VALUED_ALIAS_ALIASES = "bigquery_table_valued_alias_aliases"
7171

72+
from sqlalchemy.testing.provision import create_db, drop_db
73+
@create_db.for_db("bigquery")
74+
def _bigquery_create_db(cfg, eng, ident):
75+
# This and _bigquery_drop_db are adequate to get past the errors generated when using xdist:
76+
# NotImplementedError: no DB creation routine for cfg
77+
# NotImplementedError: no DB drop routine for cfg
78+
#
79+
# HOWEVER... we need to populate this in some way to create dbs that
80+
# work. THere are examples of create_db style functions in various
81+
# dialects provision.py files.
82+
# This sqlalchemy issue speaks to this problem:
83+
# https://github.com/sqlalchemy/sqlalchemy/discussions/10948
84+
pass
85+
86+
@drop_db.for_db("bigquery")
87+
def _bigquery_drop_db(cfg, eng, ident):
88+
pass # _drop_dbs_w_ident(eng.url.database, eng.driver, ident)
89+
# SEE note above for create_db
90+
7291

7392
def assert_(cond, message="Assertion failed"): # pragma: NO COVER
7493
if not cond:

0 commit comments

Comments
 (0)