🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Author: gcf-owl-bot[bot]

handwritten/storage/internal-tooling/performApplicationPerformanceTest.ts

@@ -56,7 +56,7 @@ async function main() {
 
   ({bucket} = await performanceTestSetup(
     argv.project! as string,
-    argv.bucket! as string
+    argv.bucket! as string,
   ));
 
   switch (argv.test_type) {
@@ -78,7 +78,7 @@ async function main() {
 async function uploadInParallel(
   bucket: Bucket,
   paths: string[],
-  options: UploadOptions
+  options: UploadOptions,
 ) {
   const promises: Promise<UploadResponse>[] = [];
   for (const index in paths) {
@@ -115,7 +115,7 @@ async function performWriteTest(): Promise<TestResult> {
     argv.num_objects as number,
     TEST_NAME_STRING,
     fileSizeRange.low,
-    fileSizeRange.high
+    fileSizeRange.high,
   );
 
   const start = performance.now();
@@ -157,7 +157,7 @@ async function performReadTest(): Promise<TestResult> {
     argv.num_objects as number,
     TEST_NAME_STRING,
     fileSizeRange.low,
-    fileSizeRange.high
+    fileSizeRange.high,
   );
   await uploadInParallel(bucket, creationInfo.paths, {validation: checkType});
 

handwritten/storage/internal-tooling/performPerformanceTest.ts

@@ -54,7 +54,7 @@ async function main() {
 
   ({bucket} = await performanceTestSetup(
     argv.project! as string,
-    argv.bucket! as string
+    argv.bucket! as string,
   ));
 
   switch (argv.test_type) {
@@ -84,7 +84,7 @@ async function performRangedReadTest(): Promise<TestResult[]> {
     fileName,
     fileSizeRange.low,
     fileSizeRange.high,
-    getDirName()
+    getDirName(),
   );
   const file = bucket.file(`${fileName}`);
   const destinationFileName = generateRandomFileName(TEST_NAME_STRING);
@@ -142,7 +142,7 @@ async function performWriteReadTest(): Promise<TestResult[]> {
     fileName,
     fileSizeRange.low,
     fileSizeRange.high,
-    getDirName()
+    getDirName(),
   );
 
   for (let j = 0; j < DEFAULT_NUMBER_OF_WRITES; j++) {

handwritten/storage/internal-tooling/performTransferManagerTest.ts

@@ -56,7 +56,7 @@ async function main() {
 
   ({bucket, transferManager} = await performanceTestSetup(
     argv.project! as string,
-    argv.bucket! as string
+    argv.bucket! as string,
   ));
 
   switch (argv.test_type) {
@@ -104,7 +104,7 @@ async function performUploadManyFilesTest(): Promise<TestResult[]> {
     TEST_NAME_STRING,
     fileSizeRange.low,
     fileSizeRange.high,
-    DIRECTORY_PROBABILITY
+    DIRECTORY_PROBABILITY,
   );
 
   const start = performance.now();
@@ -153,7 +153,7 @@ async function performDownloadManyFilesTest(): Promise<TestResult[]> {
     TEST_NAME_STRING,
     fileSizeRange.low,
     fileSizeRange.high,
-    DIRECTORY_PROBABILITY
+    DIRECTORY_PROBABILITY,
   );
 
   await transferManager.uploadManyFiles(creationInfo.paths, {
@@ -210,7 +210,7 @@ async function performChunkUploadDownloadTest(): Promise<TestResult[]> {
     fileName,
     fileSizeRange.low,
     fileSizeRange.high,
-    getDirName()
+    getDirName(),
   );
   const file = bucket.file(`${fileName}`);
   let result: TestResult = {

handwritten/storage/internal-tooling/performanceTest.ts

@@ -44,7 +44,7 @@ function main() {
   if (numThreads > iterationsRemaining) {
     log(
       `${numThreads} is greater than number of iterations (${iterationsRemaining}). Using ${iterationsRemaining} threads instead.`,
-      argv.debug as boolean
+      argv.debug as boolean,
     );
     numThreads = iterationsRemaining;
   }
@@ -65,7 +65,7 @@ function createWorker() {
   iterationsRemaining--;
   log(
     `Starting new iteration. Current iterations remaining: ${iterationsRemaining}`,
-    argv.debug as boolean
+    argv.debug as boolean,
   );
   let testPath = '';
   if (
@@ -122,7 +122,7 @@ async function recordResult(results: TestResult[] | TestResult) {
     : [results];
 
   for await (const outputString of convertToCloudMonitoringFormat(
-    resultsToAppend
+    resultsToAppend,
   )) {
     argv.file_name
       ? await appendFile(argv.file_name as string, `${outputString}\n`)

handwritten/storage/internal-tooling/performanceUtils.ts

@@ -214,20 +214,20 @@ export function generateRandomFileName(baseName: string): string {
 export function generateRandomFile(
   fileName: string,
   fileSizeLowerBoundBytes: number = getLowHighFileSize(
-    DEFAULT_OBJECT_RANGE_SIZE_BYTES
+    DEFAULT_OBJECT_RANGE_SIZE_BYTES,
   ).low,
   fileSizeUpperBoundBytes: number = getLowHighFileSize(
-    DEFAULT_OBJECT_RANGE_SIZE_BYTES
+    DEFAULT_OBJECT_RANGE_SIZE_BYTES,
   ).high,
-  currentDirectory: string = mkdtempSync(randomString())
+  currentDirectory: string = mkdtempSync(randomString()),
 ): number {
   const fileSizeBytes = randomInteger(
     fileSizeLowerBoundBytes,
-    fileSizeUpperBoundBytes
+    fileSizeUpperBoundBytes,
   );
 
   execSync(
-    `head --bytes=${fileSizeBytes} /dev/urandom > ${currentDirectory}/${fileName}`
+    `head --bytes=${fileSizeBytes} /dev/urandom > ${currentDirectory}/${fileName}`,
   );
 
   return fileSizeBytes;
@@ -247,12 +247,12 @@ export function generateRandomDirectoryStructure(
   maxObjects: number,
   baseName: string,
   fileSizeLowerBoundBytes: number = getLowHighFileSize(
-    DEFAULT_OBJECT_RANGE_SIZE_BYTES
+    DEFAULT_OBJECT_RANGE_SIZE_BYTES,
   ).low,
   fileSizeUpperBoundBytes: number = getLowHighFileSize(
-    DEFAULT_OBJECT_RANGE_SIZE_BYTES
+    DEFAULT_OBJECT_RANGE_SIZE_BYTES,
   ).high,
-  directoryProbability: number = DEFAULT_DIRECTORY_PROBABILITY
+  directoryProbability: number = DEFAULT_DIRECTORY_PROBABILITY,
 ): RandomDirectoryCreationInformation {
   let curPath = baseName;
   const creationInfo: RandomDirectoryCreationInformation = {
@@ -272,7 +272,7 @@ export function generateRandomDirectoryStructure(
         randomName,
         fileSizeLowerBoundBytes,
         fileSizeUpperBoundBytes,
-        curPath
+        curPath,
       );
       creationInfo.paths.push(path.join(curPath, randomName));
     }
@@ -288,7 +288,7 @@ export function generateRandomDirectoryStructure(
  */
 export function cleanupFile(
   fileName: string,
-  directoryName: string = getDirName()
+  directoryName: string = getDirName(),
 ): void {
   unlinkSync(`${directoryName}/${fileName}`);
 }
@@ -302,7 +302,7 @@ export function cleanupFile(
  */
 export async function performanceTestSetup(
   projectId: string,
-  bucketName: string
+  bucketName: string,
 ): Promise<PerformanceTestSetupResults> {
   const storage = new Storage({projectId});
   const bucket = storage.bucket(bucketName, {
@@ -346,7 +346,7 @@ export function getValidationType(): 'md5' | 'crc32c' | boolean | undefined {
  * @returns {AsyncGenerator<string>} A string containing the results of the conversion to cloud monitoring format.
  */
 export async function* convertToCloudMonitoringFormat(
-  results: TestResult[]
+  results: TestResult[],
 ): AsyncGenerator<string> {
   for (const curResult of results) {
     const throughput =
@@ -384,7 +384,7 @@ export async function* convertToCloudMonitoringFormat(
 export function log(
   messageOrError: string | Error,
   shouldLog: boolean,
-  isError = false
+  isError = false,
 ): void {
   if (shouldLog) {
     isError ? console.error(messageOrError) : console.log(messageOrError);

handwritten/storage/src/acl.ts

@@ -23,7 +23,7 @@ export interface AclOptions {
   pathPrefix: string;
   request: (
     reqOpts: DecorateRequestOptions,
-    callback: BodyResponseCallback
+    callback: BodyResponseCallback,
   ) => void;
 }
 
@@ -35,7 +35,7 @@ export interface GetAclCallback {
   (
     err: Error | null,
     acl?: AccessControlObject | AccessControlObject[] | null,
-    apiResponse?: AclMetadata
+    apiResponse?: AclMetadata,
   ): void;
 }
 export interface GetAclOptions {
@@ -55,7 +55,7 @@ export interface UpdateAclCallback {
   (
     err: Error | null,
     acl?: AccessControlObject | null,
-    apiResponse?: AclMetadata
+    apiResponse?: AclMetadata,
   ): void;
 }
 
@@ -70,7 +70,7 @@ export interface AddAclCallback {
   (
     err: Error | null,
     acl?: AccessControlObject | null,
-    apiResponse?: AclMetadata
+    apiResponse?: AclMetadata,
   ): void;
 }
 export type RemoveAclResponse = [AclMetadata];
@@ -331,7 +331,7 @@ class AclRoleAccessorMethods {
         (acc as any)[method] = (
           entityId: string,
           options: {},
-          callback: Function | {}
+          callback: Function | {},
         ) => {
           let apiEntity;
 
@@ -355,7 +355,7 @@ class AclRoleAccessorMethods {
               entity: apiEntity,
               role,
             },
-            options
+            options,
           );
 
           const args = [options];
@@ -420,7 +420,7 @@ class Acl extends AclRoleAccessorMethods {
   pathPrefix: string;
   request_: (
     reqOpts: DecorateRequestOptions,
-    callback: BodyResponseCallback
+    callback: BodyResponseCallback,
   ) => void;
 
   constructor(options: AclOptions) {
@@ -508,7 +508,7 @@ class Acl extends AclRoleAccessorMethods {
    */
   add(
     options: AddAclOptions,
-    callback?: AddAclCallback
+    callback?: AddAclCallback,
   ): void | Promise<AddAclResponse> {
     const query = {} as AclQuery;
 
@@ -538,7 +538,7 @@ class Acl extends AclRoleAccessorMethods {
         }
 
         callback!(null, this.makeAclObject_(resp), resp);
-      }
+      },
     );
   }
 
@@ -608,7 +608,7 @@ class Acl extends AclRoleAccessorMethods {
    */
   delete(
     options: RemoveAclOptions,
-    callback?: RemoveAclCallback
+    callback?: RemoveAclCallback,
   ): void | Promise<RemoveAclResponse> {
     const query = {} as AclQuery;
 
@@ -628,7 +628,7 @@ class Acl extends AclRoleAccessorMethods {
       },
       (err, resp) => {
         callback!(err, resp);
-      }
+      },
     );
   }
 
@@ -722,7 +722,7 @@ class Acl extends AclRoleAccessorMethods {
    */
   get(
     optionsOrCallback?: GetAclOptions | GetAclCallback,
-    cb?: GetAclCallback
+    cb?: GetAclCallback,
   ): void | Promise<GetAclResponse> {
     const options =
       typeof optionsOrCallback === 'object' ? optionsOrCallback : null;
@@ -763,7 +763,7 @@ class Acl extends AclRoleAccessorMethods {
         }
 
         callback!(null, results, resp);
-      }
+      },
     );
   }
 
@@ -830,7 +830,7 @@ class Acl extends AclRoleAccessorMethods {
    */
   update(
     options: UpdateAclOptions,
-    callback?: UpdateAclCallback
+    callback?: UpdateAclCallback,
   ): void | Promise<UpdateAclResponse> {
     const query = {} as AclQuery;
 
@@ -858,7 +858,7 @@ class Acl extends AclRoleAccessorMethods {
         }
 
         callback!(null, this.makeAclObject_(resp), resp);
-      }
+      },
     );
   }
 
@@ -868,7 +868,7 @@ class Acl extends AclRoleAccessorMethods {
    * @private
    */
   makeAclObject_(
-    accessControlObject: AccessControlObject
+    accessControlObject: AccessControlObject,
   ): AccessControlObject {
     const obj = {
       entity: accessControlObject.entity,
@@ -895,7 +895,7 @@ class Acl extends AclRoleAccessorMethods {
    */
   request(
     reqOpts: DecorateRequestOptions,
-    callback: BodyResponseCallback
+    callback: BodyResponseCallback,
   ): void {
     reqOpts.uri = this.pathPrefix + reqOpts.uri;
     this.request_(reqOpts, callback);