Skip to content

Commit da12b8b

Browse files
chore(EventBuilder): update character limits for session_id, session_number (#2262)
* update character limits for event parameters * update wording in tests * remove character limit validation on event parameter values * remove commented out code
1 parent f94e627 commit da12b8b

3 files changed

Lines changed: 1 addition & 13 deletions

File tree

src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/custom.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ export const customSchema = {
1313
"type": "object",
1414
"required": [],
1515
"maxProperties": 25,
16-
"patternProperties": {
17-
".": {
18-
"maxLength": 100
19-
}
20-
},
2116
"propertyNames": {
2217
"pattern": "^(?!ga_|google_|firebase_)[A-Za-z][A-Za-z0-9_]*$",
2318
"maxLength": 40

src/components/ga4/EventBuilder/ValidateEvent/schemas/schemaBuilder.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ export const buildEvents = () => {
3737
"^(?!ga_|google_|firebase_)[A-Za-z][A-Za-z0-9_]*$",
3838
"maxLength":
3939
40
40-
},
41-
"patternProperties": {
42-
".": {
43-
"maxLength": 100
44-
}
4540
}
4641
}
4742
}

src/components/ga4/EventBuilder/index.spec.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,13 +176,11 @@ describe("Event Builder", () => {
176176
// event categories so if it's broken, it's probably fine to just
177177
// change the expected values.
178178
const ecInput = within(eventCategory).getByRole("combobox")
179-
//eventCategory.focus()
180179
renderer.fireEvent.change(ecInput, {
181180
target: { value: "All apps" },
182181
})
183182

184183
const enInput = within(eventName).getByRole("combobox")
185-
//eventCategory.focus()
186184
renderer.fireEvent.change(enInput, {
187185
target: { value: "campaign_details" },
188186
})
@@ -227,4 +225,4 @@ describe("Event Builder", () => {
227225
expect(adImpression).toBeNull()
228226
})
229227
})
230-
})
228+
})

0 commit comments

Comments
 (0)