Skip to content

Commit 202c46d

Browse files
authored
Remove an option to include access token to the URL generated by Query (#1249)
Explorer
1 parent ebf248b commit 202c46d

2 files changed

Lines changed: 1 addition & 17 deletions

File tree

src/components/QueryExplorer/Report.tsx

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ import Spinner from "../../components/Spinner"
3030
import { CopyIconButton } from "../../components/CopyButton"
3131
import { QueryResponse, APIStatus } from "./useDataAPIRequest"
3232
import TSVDownload from "./TSVDownload"
33-
import LabeledCheckbox from "../LabeledCheckbox"
34-
import { useState } from "react"
3533

3634
const useStyles = makeStyles(theme => ({
3735
paper: {},
@@ -93,17 +91,14 @@ interface ReportProps {
9391
queryResponse: QueryResponse
9492
columns: gapi.client.analytics.Column[] | undefined
9593
permalink: string | undefined
96-
accessToken: string | undefined
9794
}
9895

9996
const Report: React.FC<ReportProps> = ({
10097
queryResponse,
10198
columns,
10299
permalink,
103-
accessToken,
104100
}) => {
105101
const classes = useStyles()
106-
const [includeAccessToken, setIncludeAccessToken] = useState(false)
107102

108103
const requestURL = React.useMemo(() => {
109104
if (
@@ -115,14 +110,11 @@ const Report: React.FC<ReportProps> = ({
115110
const [base, queryParamString] = queryResponse.response.selfLink!.split("?")
116111
const existingQueryParams = new URLSearchParams(queryParamString)
117112
const nuQueryParams = new URLSearchParams()
118-
if (includeAccessToken && accessToken !== undefined) {
119-
nuQueryParams.append("access_token", accessToken)
120-
}
121113
existingQueryParams.forEach((value, key) => {
122114
nuQueryParams.append(key, value)
123115
})
124116
return `${base}?${nuQueryParams.toString()}`
125-
}, [queryResponse, includeAccessToken, accessToken])
117+
}, [queryResponse])
126118

127119
if (queryResponse === undefined) {
128120
return null
@@ -181,12 +173,6 @@ const Report: React.FC<ReportProps> = ({
181173
),
182174
}}
183175
/>
184-
<LabeledCheckbox
185-
checked={includeAccessToken}
186-
setChecked={setIncludeAccessToken}
187-
>
188-
include access token
189-
</LabeledCheckbox>
190176
<section className={classes.reportLink}>
191177
<a href={permalink}>Link to this report</a>
192178
</section>

src/components/QueryExplorer/index.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ export const QueryExplorer = () => {
195195
runQuery,
196196
requiredParameters,
197197
queryResponse,
198-
accessToken,
199198
} = useDataAPIRequest({
200199
viewID,
201200
startDate,
@@ -407,7 +406,6 @@ export const QueryExplorer = () => {
407406
</LabeledCheckbox>
408407
</section>
409408
<Report
410-
accessToken={accessToken}
411409
queryResponse={queryResponse}
412410
columns={successful(uaDimensionsAndMetricsRequest)?.columns}
413411
permalink={currentLink}

0 commit comments

Comments
 (0)