Skip to content

Commit 4a5ed2d

Browse files
authored
Set default for brand_guidelines_enabled to True in Pmax examples. (#1060)
1 parent 8d4285a commit 4a5ed2d

2 files changed

Lines changed: 18 additions & 9 deletions

File tree

examples/advanced_operations/add_performance_max_campaign.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -978,7 +978,7 @@ def create_asset_group_signal_operations(
978978
"-b",
979979
"--brand_guidelines_enabled",
980980
type=bool,
981-
default=False,
981+
default=True,
982982
help=(
983983
"A boolean value indicating if the created campaign is enabled "
984984
"for brand guidelines."

examples/shopping_ads/add_performance_max_retail_campaign.py

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
https://developers.google.com/google-ads/api/docs/conversions/overview#conversion_actions
3535
"""
3636

37-
3837
import argparse
3938
from datetime import datetime, timedelta
4039
import sys
@@ -390,20 +389,30 @@ def create_performance_max_campaign_operation(
390389
)
391390

392391
# Optional fields
393-
campaign.start_date_time = (datetime.now() + timedelta(1)).strftime("%Y%m%d 00:00:00")
394-
campaign.end_date_time = (datetime.now() + timedelta(365)).strftime("%Y%m%d 23:59:59")
392+
campaign.start_date_time = (datetime.now() + timedelta(1)).strftime(
393+
"%Y%m%d 00:00:00"
394+
)
395+
campaign.end_date_time = (datetime.now() + timedelta(365)).strftime(
396+
"%Y%m%d 23:59:59"
397+
)
395398

396399
# Configures the optional opt-in/out status for asset automation settings.
397400
for asset_automation_type_enum in [
398401
client.enums.AssetAutomationTypeEnum.GENERATE_IMAGE_EXTRACTION,
399402
client.enums.AssetAutomationTypeEnum.FINAL_URL_EXPANSION_TEXT_ASSET_AUTOMATION,
400403
client.enums.AssetAutomationTypeEnum.TEXT_ASSET_AUTOMATION,
401404
client.enums.AssetAutomationTypeEnum.GENERATE_ENHANCED_YOUTUBE_VIDEOS,
402-
client.enums.AssetAutomationTypeEnum.GENERATE_IMAGE_ENHANCEMENT
405+
client.enums.AssetAutomationTypeEnum.GENERATE_IMAGE_ENHANCEMENT,
403406
]:
404-
asset_automattion_setting: Campaign.AssetAutomationSetting = client.get_type("Campaign").AssetAutomationSetting()
405-
asset_automattion_setting.asset_automation_type = asset_automation_type_enum
406-
asset_automattion_setting.asset_automation_status = client.enums.AssetAutomationStatusEnum.OPTED_IN
407+
asset_automattion_setting: Campaign.AssetAutomationSetting = (
408+
client.get_type("Campaign").AssetAutomationSetting()
409+
)
410+
asset_automattion_setting.asset_automation_type = (
411+
asset_automation_type_enum
412+
)
413+
asset_automattion_setting.asset_automation_status = (
414+
client.enums.AssetAutomationStatusEnum.OPTED_IN
415+
)
407416
campaign.asset_automation_settings.append(asset_automattion_setting)
408417

409418
return mutate_operation
@@ -1239,7 +1248,7 @@ def print_response_details(response: MutateGoogleAdsResponse) -> None:
12391248
"-b",
12401249
"--brand_guidelines_enabled",
12411250
type=bool,
1242-
default=False,
1251+
default=True,
12431252
help=(
12441253
"A boolean value indicating if the created campaign is enabled "
12451254
"for brand guidelines."

0 commit comments

Comments
 (0)