Address compiler warnings

* Add `override`
* Explicitly delete the move constructor and move assignment operator for
`DeadlineRegistration`. Defaulting still implicitly deleted them because of
the reference member `manager_`.
* Add `absl_nonnull` annotations to pointer arguments in `ElfParser::Load()` methods.

PiperOrigin-RevId: 902545952
Change-Id: Iaead6fff09ded05fd7e6c34106e55c75755862b8

Author: cblichmann

sandboxed_api/sandbox2/util/deadline_manager.h

@@ -47,8 +47,8 @@ class DeadlineRegistration {
   DeadlineRegistration(const DeadlineRegistration&) = delete;
   DeadlineRegistration& operator=(const DeadlineRegistration&) = delete;
 
-  DeadlineRegistration(DeadlineRegistration&&) = default;
-  DeadlineRegistration& operator=(DeadlineRegistration&&) = default;
+  DeadlineRegistration(DeadlineRegistration&&) = delete;
+  DeadlineRegistration& operator=(DeadlineRegistration&&) = delete;
 
   ~DeadlineRegistration();
 

sandboxed_api/sandbox2/util/elf_parser.h

@@ -136,15 +136,15 @@ class ElfParser {
   ElfParser(const ElfParser&) = delete;
   ElfParser& operator=(const ElfParser&) = delete;
 
-  // Endianess support functions
+  // Endianness support functions
   uint16_t Load16(const void* absl_nonnull src);
   uint32_t Load32(const void* absl_nonnull src);
   uint64_t Load64(const void* absl_nonnull src);
   template <size_t N>
-  void Load(unsigned char (*dst)[N], const void* src);
+  void Load(unsigned char (*absl_nonnull dst)[N], const void* absl_nonnull src);
   template <typename IntT>
-  std::enable_if_t<std::is_integral_v<IntT>, void> Load(IntT* dst,
-                                                        const void* src);
+  std::enable_if_t<std::is_integral_v<IntT>, void> Load(
+      IntT* absl_nonnull dst, const void* absl_nonnull src);
   // Lazy constructor.
   absl::Status Init(std::string filename, sapi::file_util::fileops::FDCloser fd,
                     bool mmap_file);

sandboxed_api/tools/clang_generator/generator.h

@@ -147,7 +147,7 @@ class GeneratorAction : public clang::ASTFrontendAction {
                                                   emitter_, options_);
   }
 
-  bool BeginSourceFileAction(clang::CompilerInstance& ci);
+  bool BeginSourceFileAction(clang::CompilerInstance& ci) override;
 
   bool hasCodeCompletionSupport() const override { return false; }