Merge pull request #157 from ModelRocket/fix/middleware-context

casualjim · web-flow · commit c909caa33886 · 2019-09-12T08:10:43.000-07:00
Fixing issue where context modifications in authenticators are ignored
diff --git a/middleware/context.go b/middleware/context.go
@@ -433,6 +433,8 @@ func (c *Context) Authorize(request *http.Request, route *MatchedRoute) (interfa
 		}
 	}
 
+	rCtx = request.Context()
+
 	rCtx = stdContext.WithValue(rCtx, ctxSecurityPrincipal, usr)
 	rCtx = stdContext.WithValue(rCtx, ctxSecurityScopes, route.Authenticator.AllScopes())
 	return usr, request.WithContext(rCtx), nil

Original file line number	Diff line number	Diff line change
`@@ -433,6 +433,8 @@ func (c Context) Authorize(request http.Request, route *MatchedRoute) (interfa`
`433`	`433`	`}`
`434`	`434`	`}`
`435`	`435`
	`436`	`+ rCtx = request.Context()`
	`437`	`+`
`436`	`438`	`rCtx = stdContext.WithValue(rCtx, ctxSecurityPrincipal, usr)`
`437`	`439`	`rCtx = stdContext.WithValue(rCtx, ctxSecurityScopes, route.Authenticator.AllScopes())`
`438`	`440`	`return usr, request.WithContext(rCtx), nil`