Merge pull request #5 from github/kill-labels

🔥 the TaskList item label

Author: mtodd

app/assets/javascripts/task_lists.coffee

@@ -15,10 +15,8 @@
 #   <div class="js-task-list-container">
 #     <ul class="task-list">
 #       <li class="task-list-item">
-#         <label>
-#           <input type="checkbox" class="js-task-list-item-checkbox" disabled />
-#           text
-#         </label>
+#         <input type="checkbox" class="js-task-list-item-checkbox" disabled />
+#         text
 #       </li>
 #     </ul>
 #     <form>
@@ -33,7 +31,7 @@
 # TaskList Items SHOULD be an a list (`UL`/`OL`) element.
 #
 # Task list items MUST match `(input).task-list-item-checkbox` and MUST be
-# `disabled` by default. The Item's contents SHOULD be wrapped in a `LABEL`.
+# `disabled` by default.
 #
 # TaskLists MUST have a `(textarea).js-task-list-field` form element whose
 # `value` attribute is the source (Markdown) to be udpated. The source MUST

app/assets/stylesheets/task_lists.scss

@@ -10,9 +10,6 @@
 .task-list-item label {
   font-weight: normal;
 }
-.task-list-item.enabled label {
-  cursor: pointer;
-}
 .task-list-item + .task-list-item {
   margin-top: 3px;
 }

lib/task_list/filter.rb

@@ -92,11 +92,8 @@ def render_item_checkbox(item)
     #
     # Returns the marked up task list item Nokogiri::XML::NodeSet object.
     def render_task_list_item(item)
-      Nokogiri::HTML.fragment <<-html, 'utf-8'
-        <label>#{
-          item.source.sub(ItemPattern, render_item_checkbox(item))
-        }</label>
-      html
+      Nokogiri::HTML.fragment \
+        item.source.sub(ItemPattern, render_item_checkbox(item)), 'utf-8'
     end
 
     # Public: Select all task lists from the `doc`.

test/functional/test_task_lists_behavior.html

@@ -71,10 +71,8 @@
     <div class="markdown">
       <ul class="task-list">
         <li class="task-list-item">
-          <label>
-            <input type="checkbox" class="task-list-item-checkbox" disabled />
-            I'm a task list item
-          </label>
+          <input type="checkbox" class="task-list-item-checkbox" disabled />
+          I'm a task list item
         </li>
       </ul>
     </div>