Write record fields to the heap in the abstract analyses.

Author: robrix

semantic-core/src/Analysis/ImportGraph.hs

@@ -15,7 +15,7 @@ import           Control.Effect.Reader
 import           Control.Effect.State
 import           Control.Monad ((>=>))
 import           Data.File
-import           Data.Foldable (fold)
+import           Data.Foldable (fold, for_)
 import           Data.Function (fix)
 import           Data.List.NonEmpty (nonEmpty)
 import           Data.Loc
@@ -118,5 +118,9 @@ importGraphAnalysis = Analysis{..}
         string s = pure (Value (String s) mempty)
         asString (Value (String s) _) = pure s
         asString _ = pure mempty
-        record fields = pure (Value Abstract (foldMap (valueGraph . snd) fields))
+        record fields = do
+          for_ fields $ \ (k, v) -> do
+            addr <- alloc k
+            assign addr v
+          pure (Value Abstract (foldMap (valueGraph . snd) fields))
         _ ... m = pure (Just m)

semantic-core/src/Analysis/ScopeGraph.hs

@@ -16,7 +16,7 @@ import           Control.Effect.Reader
 import           Control.Effect.State
 import           Control.Monad ((>=>))
 import           Data.File
-import           Data.Foldable (fold)
+import           Data.Foldable (fold, for_)
 import           Data.Function (fix)
 import           Data.List.NonEmpty
 import           Data.Loc
@@ -104,5 +104,9 @@ scopeGraphAnalysis = Analysis{..}
         asBool _ = pure True <|> pure False
         string _ = pure mempty
         asString _ = pure mempty
-        record fields = pure (foldMap snd fields)
+        record fields = do
+          for_ fields $ \ (k, v) -> do
+            addr <- alloc k
+            assign addr v
+          pure (foldMap snd fields)
         _ ... m = pure (Just m)

semantic-core/src/Analysis/Typecheck.hs

@@ -33,6 +33,7 @@ import           Data.Scope
 import           Data.Semigroup (Last (..))
 import qualified Data.Set as Set
 import           Data.Term
+import           Data.Traversable (for)
 import           Data.Void
 import           GHC.Generics (Generic1)
 import           Prelude hiding (fail)
@@ -173,7 +174,12 @@ typecheckingAnalysis = Analysis{..}
         asBool b = unify (Term Bool) b >> pure True <|> pure False
         string _ = pure (Term String)
         asString s = unify (Term String) s $> mempty
-        record fields = pure (Term (Record (Map.fromList fields)))
+        record fields = do
+          fields' <- for fields $ \ (k, v) -> do
+            addr <- alloc k
+            (k, v) <$ assign addr v
+          -- FIXME: should records reference types by address instead?
+          pure (Term (Record (Map.fromList fields')))
         _ ... m = pure (Just m)