Fix memoryWatchStage.Wait() to always call stopWatching() #157
znullAnnotations
7 errors and 1 warning
|
golangci
issues found
|
|
golangci:
pipe/pipeline.go#L32
ST1012: error var FinishEarly should have name of the form ErrFoo (staticcheck)
|
|
golangci:
pipe/pipeline_test.go#L1055
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci:
pipe/pipeline_test.go#L1028
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci:
pipe/pipeline_test.go#L1010
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci:
pipe/pipeline.go#L71
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci:
pipe/pipe_matching_test.go#L363
The copy of the 'for' variable "tc" can be deleted (Go 1.22+) (copyloopvar)
|
|
golangci
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v3, actions/setup-go@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|