Remove ReadByte, WriteByte, ReadRune, WriteRune

Author: gagliardetto

ql/src/semmle/go/frameworks/stdlib/Bufio.qll

@@ -70,10 +70,6 @@ module Bufio {
       this.hasQualifiedName("bufio", "Reader", "Peek") and
       (inp.isReceiver() and outp.isResult(0))
       or
-      // signature: func (*Reader).ReadByte() (byte, error)
-      this.hasQualifiedName("bufio", "Reader", "ReadByte") and
-      (inp.isReceiver() and outp.isResult(0))
-      or
       // signature: func (*Reader).ReadBytes(delim byte) ([]byte, error)
       this.hasQualifiedName("bufio", "Reader", "ReadBytes") and
       (inp.isReceiver() and outp.isResult(0))
@@ -82,10 +78,6 @@ module Bufio {
       this.hasQualifiedName("bufio", "Reader", "ReadLine") and
       (inp.isReceiver() and outp.isResult(0))
       or
-      // signature: func (*Reader).ReadRune() (r rune, size int, err error)
-      this.hasQualifiedName("bufio", "Reader", "ReadRune") and
-      (inp.isReceiver() and outp.isResult(0))
-      or
       // signature: func (*Reader).ReadSlice(delim byte) (line []byte, err error)
       this.hasQualifiedName("bufio", "Reader", "ReadSlice") and
       (inp.isReceiver() and outp.isResult(0))
@@ -122,14 +114,6 @@ module Bufio {
       this.hasQualifiedName("bufio", "Writer", "Write") and
       (inp.isParameter(0) and outp.isReceiver())
       or
-      // signature: func (*Writer).WriteByte(c byte) error
-      this.hasQualifiedName("bufio", "Writer", "WriteByte") and
-      (inp.isParameter(0) and outp.isReceiver())
-      or
-      // signature: func (*Writer).WriteRune(r rune) (size int, err error)
-      this.hasQualifiedName("bufio", "Writer", "WriteRune") and
-      (inp.isParameter(0) and outp.isReceiver())
-      or
       // signature: func (*Writer).WriteString(s string) (int, error)
       this.hasQualifiedName("bufio", "Writer", "WriteString") and
       (inp.isParameter(0) and outp.isReceiver())

ql/src/semmle/go/frameworks/stdlib/Bytes.qll

@@ -158,10 +158,6 @@ module Bytes {
       this.hasQualifiedName("bytes", "Buffer", "Next") and
       (inp.isReceiver() and outp.isResult())
       or
-      // signature: func (*Buffer).ReadByte() (byte, error)
-      this.hasQualifiedName("bytes", "Buffer", "ReadByte") and
-      (inp.isReceiver() and outp.isResult(0))
-      or
       // signature: func (*Buffer).ReadBytes(delim byte) (line []byte, err error)
       this.hasQualifiedName("bytes", "Buffer", "ReadBytes") and
       (inp.isReceiver() and outp.isResult(0))
@@ -170,10 +166,6 @@ module Bytes {
       this.hasQualifiedName("bytes", "Buffer", "ReadFrom") and
       (inp.isParameter(0) and outp.isReceiver())
       or
-      // signature: func (*Buffer).ReadRune() (r rune, size int, err error)
-      this.hasQualifiedName("bytes", "Buffer", "ReadRune") and
-      (inp.isReceiver() and outp.isResult(0))
-      or
       // signature: func (*Buffer).ReadString(delim byte) (line string, err error)
       this.hasQualifiedName("bytes", "Buffer", "ReadString") and
       (inp.isReceiver() and outp.isResult(0))
@@ -186,14 +178,6 @@ module Bytes {
       this.hasQualifiedName("bytes", "Buffer", "Write") and
       (inp.isParameter(0) and outp.isReceiver())
       or
-      // signature: func (*Buffer).WriteByte(c byte) error
-      this.hasQualifiedName("bytes", "Buffer", "WriteByte") and
-      (inp.isParameter(0) and outp.isReceiver())
-      or
-      // signature: func (*Buffer).WriteRune(r rune) (n int, err error)
-      this.hasQualifiedName("bytes", "Buffer", "WriteRune") and
-      (inp.isParameter(0) and outp.isReceiver())
-      or
       // signature: func (*Buffer).WriteString(s string) (n int, err error)
       this.hasQualifiedName("bytes", "Buffer", "WriteString") and
       (inp.isParameter(0) and outp.isReceiver())
@@ -206,14 +190,6 @@ module Bytes {
       this.hasQualifiedName("bytes", "Reader", "ReadAt") and
       (inp.isReceiver() and outp.isParameter(0))
       or
-      // signature: func (*Reader).ReadByte() (byte, error)
-      this.hasQualifiedName("bytes", "Reader", "ReadByte") and
-      (inp.isReceiver() and outp.isResult(0))
-      or
-      // signature: func (*Reader).ReadRune() (ch rune, size int, err error)
-      this.hasQualifiedName("bytes", "Reader", "ReadRune") and
-      (inp.isReceiver() and outp.isResult(0))
-      or
       // signature: func (*Reader).Reset(b []byte)
       this.hasQualifiedName("bytes", "Reader", "Reset") and
       (inp.isParameter(0) and outp.isReceiver())