Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Commit d472d5a

Browse files
committed
Remove redundant taint-tracking from MarshalingFunction and UnmarshalingFunction classes in EncodingJson module.
1 parent ed2e5b0 commit d472d5a

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

ql/src/semmle/go/frameworks/stdlib/EncodingJson.qll

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,30 +13,22 @@ module EncodingJson {
1313
}
1414

1515
/** The `Marshal` or `MarshalIndent` function in the `encoding/json` package. */
16-
class MarshalFunction extends TaintTracking::FunctionModel, MarshalingFunction::Range {
16+
class MarshalFunction extends MarshalingFunction::Range {
1717
MarshalFunction() {
1818
this.hasQualifiedName("encoding/json", "Marshal") or
1919
this.hasQualifiedName("encoding/json", "MarshalIndent")
2020
}
2121

22-
override predicate hasTaintFlow(FunctionInput inp, FunctionOutput outp) {
23-
inp = getAnInput() and outp = getOutput()
24-
}
25-
2622
override FunctionInput getAnInput() { result.isParameter(0) }
2723

2824
override FunctionOutput getOutput() { result.isResult(0) }
2925

3026
override string getFormat() { result = "JSON" }
3127
}
3228

33-
private class UnmarshalFunction extends TaintTracking::FunctionModel, UnmarshalingFunction::Range {
29+
private class UnmarshalFunction extends UnmarshalingFunction::Range {
3430
UnmarshalFunction() { this.hasQualifiedName("encoding/json", "Unmarshal") }
3531

36-
override predicate hasTaintFlow(FunctionInput inp, FunctionOutput outp) {
37-
inp = getAnInput() and outp = getOutput()
38-
}
39-
4032
override FunctionInput getAnInput() { result.isParameter(0) }
4133

4234
override FunctionOutput getOutput() { result.isParameter(1) }

0 commit comments

Comments
 (0)