Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Commit a47842d

Browse files
committed
Add taint-tracking for package encoding
1 parent 362d210 commit a47842d

3 files changed

Lines changed: 90 additions & 0 deletions

File tree

ql/src/semmle/go/frameworks/Stdlib.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import semmle.go.frameworks.stdlib.CompressZlib
1515
import semmle.go.frameworks.stdlib.Mime
1616
import semmle.go.frameworks.stdlib.MimeMultipart
1717
import semmle.go.frameworks.stdlib.MimeQuotedprintable
18+
import semmle.go.frameworks.stdlib.Encoding
1819
import semmle.go.frameworks.stdlib.Path
1920
import semmle.go.frameworks.stdlib.PathFilepath
2021
import semmle.go.frameworks.stdlib.Reflect
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
/**
2+
* Provides classes modeling security-relevant aspects of the `encoding` package.
3+
*/
4+
5+
import go
6+
7+
/** Provides models of commonly used functions in the `encoding` package. */
8+
module Encoding {
9+
private class MethodModels extends TaintTracking::FunctionModel, Method {
10+
FunctionInput inp;
11+
FunctionOutput outp;
12+
13+
MethodModels() {
14+
// signature: func (BinaryMarshaler).MarshalBinary() (data []byte, err error)
15+
this.implements("encoding", "BinaryMarshaler", "MarshalBinary") and
16+
(inp.isReceiver() and outp.isResult(0))
17+
or
18+
// signature: func (TextMarshaler).MarshalText() (text []byte, err error)
19+
this.implements("encoding", "TextMarshaler", "MarshalText") and
20+
(inp.isReceiver() and outp.isResult(0))
21+
or
22+
// signature: func (BinaryUnmarshaler).UnmarshalBinary(data []byte) error
23+
this.implements("encoding", "BinaryUnmarshaler", "UnmarshalBinary") and
24+
(inp.isParameter(0) and outp.isReceiver())
25+
or
26+
// signature: func (TextUnmarshaler).UnmarshalText(text []byte) error
27+
this.implements("encoding", "TextUnmarshaler", "UnmarshalText") and
28+
(inp.isParameter(0) and outp.isReceiver())
29+
}
30+
31+
override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
32+
input = inp and output = outp
33+
}
34+
}
35+
}

ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/Encoding.go

Lines changed: 54 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)