Remove redundant constraint

smowton · smowton · commit a10db25b7d27 · 2020-07-28T11:55:58.000+01:00
diff --git a/ql/src/experimental/CWE-327/InsecureTLS.ql b/ql/src/experimental/CWE-327/InsecureTLS.ql
@@ -78,7 +78,6 @@ class TlsVersionFlowConfig extends TaintTracking::Configuration {
    */
   predicate isSink(DataFlow::Node sink, Field fld, DataFlow::Node base, Write fieldWrite) {
     fld.hasQualifiedName("crypto/tls", "Config", ["MinVersion", "MaxVersion"]) and
-    fieldWrite = fld.getAWrite() and
     fieldWrite.writesField(base, fld, sink)
   }
 
@@ -207,7 +206,6 @@ class TlsInsecureCipherSuitesFlowConfig extends TaintTracking::Configuration {
    */
   predicate isSink(DataFlow::Node sink, Field fld, DataFlow::Node base, Write fieldWrite) {
     fld.hasQualifiedName("crypto/tls", "Config", "CipherSuites") and
-    fieldWrite = fld.getAWrite() and
     fieldWrite.writesField(base, fld, sink)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ class TlsVersionFlowConfig extends TaintTracking::Configuration {`
`78`	`78`	`*/`
`79`	`79`	`predicate isSink(DataFlow::Node sink, Field fld, DataFlow::Node base, Write fieldWrite) {`
`80`	`80`	`fld.hasQualifiedName("crypto/tls", "Config", ["MinVersion", "MaxVersion"]) and`
`81`		`- fieldWrite = fld.getAWrite() and`
`82`	`81`	`fieldWrite.writesField(base, fld, sink)`
`83`	`82`	`}`
`84`	`83`
`@@ -207,7 +206,6 @@ class TlsInsecureCipherSuitesFlowConfig extends TaintTracking::Configuration {`
`207`	`206`	`*/`
`208`	`207`	`predicate isSink(DataFlow::Node sink, Field fld, DataFlow::Node base, Write fieldWrite) {`
`209`	`208`	`fld.hasQualifiedName("crypto/tls", "Config", "CipherSuites") and`
`210`		`- fieldWrite = fld.getAWrite() and`
`211`	`209`	`fieldWrite.writesField(base, fld, sink)`
`212`	`210`	`}`
`213`	`211`