Simplify consistency query.

Unlike the old ODASA consistency queries, new consistency queries can have expected results, so there is no need to have special handling of files with expected errors.

Author: Max Schaefer

ql/test/consistency/CONSISTENCY/UnexpectedFrontendErrors.expected

@@ -0,0 +1 @@
+| test.go:7:1:7:1 | expected declaration, found This |

ql/test/consistency/UnexpectedFrontendErrors.expected

@@ -0,0 +1 @@
+| test.go:7:1:7:1 | expected declaration, found This |

ql/test/consistency/UnexpectedFrontendErrors.ql

@@ -1,16 +1,11 @@
 /**
  * @name Unexpected frontend error
  * @description This query produces a list of all errors produced by the Go frontend
- *              during extraction, except for those occurring in files annotated with
- *              "// codeql test: expect frontend errors".
+ *              during extraction.
  * @id go/unexpected-frontend-error
  */
 
 import go
 
 from Error e
-where
-  not exists(Comment c | c.getFile() = e.getFile() |
-    c.getText().trim() = "codeql test: expect frontend errors"
-  )
 select e

ql/test/consistency/test.go

@@ -2,8 +2,6 @@ package main
 
 // autoformat-ignore (gofmt chokes on invalid programs)
 
-// Example file with a syntax error to demonstrate use of "expect frontend errors" directive
-
-// codeql test: expect frontend errors
+// Example file with a syntax error to demonstrate use of consistency queries
 
 This is not a valid Go program

ql/test/library-tests/semmle/go/Types/CONSISTENCY/UnexpectedFrontendErrors.expected

@@ -0,0 +1 @@
+| unknownFunction.go:9:7:9:7 | undeclared name: unknownFunction |

ql/test/library-tests/semmle/go/Types/SignatureType_getNumParameter.expected

@@ -9,4 +9,4 @@
 | pkg1/tst.go:33:1:35:1 | function declaration | 0 |
 | pkg1/tst.go:37:1:37:26 | function declaration | 1 |
 | pkg1/tst.go:39:1:57:1 | function declaration | 2 |
-| unknownFunction.go:10:1:14:1 | function declaration | 0 |
+| unknownFunction.go:8:1:12:1 | function declaration | 0 |

ql/test/library-tests/semmle/go/Types/SignatureType_getNumResult.expected

@@ -9,4 +9,4 @@
 | pkg1/tst.go:33:1:35:1 | function declaration | 1 |
 | pkg1/tst.go:37:1:37:26 | function declaration | 0 |
 | pkg1/tst.go:39:1:57:1 | function declaration | 0 |
-| unknownFunction.go:10:1:14:1 | function declaration | 0 |
+| unknownFunction.go:8:1:12:1 | function declaration | 0 |

ql/test/library-tests/semmle/go/Types/notype.expected

@@ -1,3 +1,3 @@
-| unknownFunction.go:11:7:11:21 | unknownFunction | invalid type |
-| unknownFunction.go:11:7:11:23 | call to unknownFunction | invalid type |
-| unknownFunction.go:12:7:12:15 | ...+... | invalid type |
+| unknownFunction.go:9:7:9:21 | unknownFunction | invalid type |
+| unknownFunction.go:9:7:9:23 | call to unknownFunction | invalid type |
+| unknownFunction.go:10:7:10:15 | ...+... | invalid type |

ql/test/library-tests/semmle/go/Types/unknownFunction.go

@@ -1,9 +1,7 @@
 package main
 
 // This file tests type inference for expressions referencing undeclared entities.
-// It is therefore expected to expected frontend errors.
-
-// codeql test: expect frontend errors
+// It is therefore expected to produce frontend errors.
 
 import "fmt"
 

ql/test/query-tests/RedundantCode/DeadStoreOfLocal/CONSISTENCY/UnexpectedFrontendErrors.expected

@@ -0,0 +1 @@
+| main.go:36:9:36:9 | undeclared name: unknownFunction |