Skip to content

Commit 0f1e79a

Browse files
author
Thomas Mahlberg
committed
replace magic numbers with better magic numbers
1 parent 0ba3601 commit 0f1e79a

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

KustoSchemaTools/Parser/KustoWriter/DefaultDatabaseWriter.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ private async Task<List<ScriptExecuteCommandResult>> ApplyChangesToDatabase(stri
6565

6666
private async Task<ScriptExecuteCommandResult> ExecuteAsyncCommand(string databaseName, KustoClient client, ILogger logger, DatabaseScriptContainer sc)
6767
{
68-
68+
var interval = TimeSpan.FromSeconds(5);
69+
var iterations = (int)(TimeSpan.FromHours(1) / interval);
6970
var result = await client.AdminClient.ExecuteControlCommandAsync(databaseName, sc.Text);
7071
var operationId = result.ToScalar<Guid>();
7172
var finalState = false;
@@ -75,12 +76,12 @@ private async Task<ScriptExecuteCommandResult> ExecuteAsyncCommand(string databa
7576
int cnt = 0;
7677
while (!finalState)
7778
{
78-
if(cnt++ >= 3600)
79+
if(cnt++ >= iterations)
7980
{
8081
finalState = true;
8182
}
8283

83-
logger.LogInformation($"Waiting for operation {operationId} to complete... current iteration: {cnt}/3600");
84+
logger.LogInformation($"Waiting for operation {operationId} to complete... current iteration: {cnt}/{iterations}");
8485
var monitoringResult = client.Client.ExecuteQuery(databaseName, monitoringCommand, new Kusto.Data.Common.ClientRequestProperties());
8586
var operationState = monitoringResult.As<ScriptExecuteCommandResult>().FirstOrDefault();
8687

@@ -89,7 +90,7 @@ private async Task<ScriptExecuteCommandResult> ExecuteAsyncCommand(string databa
8990
operationState.CommandText = sc.Text;
9091
return operationState;
9192
}
92-
await Task.Delay(1000);
93+
await Task.Delay(interval);
9394
}
9495
throw new Exception("Operation did not complete in a reasonable time");
9596
}

0 commit comments

Comments
 (0)