Enhance input validation in Rock Paper Scissors game and update tests

Author: chrisreddington

internal/rockpaperscissors/rockpaperscissors.go

@@ -170,5 +170,11 @@ func PlayGame(prompter Prompter) {
 func parseInt(s string) int {
 	val := 3 // Default value
 	fmt.Sscanf(s, "%d", &val)
+	if val <= 0 {
+		return 3
+	}
+	if val%2 == 0 {
+		val++ // Convert even numbers to next odd number
+	}
 	return val
 }

internal/rockpaperscissors/rockpaperscissors_test.go

@@ -347,31 +347,27 @@ func TestPlayGame(t *testing.T) {
 				returns: []int{1, 0, 0, 0}, // Select 5 rounds, then rock three times
 				errors:  []error{nil, nil, nil, nil},
 			},
-			wantGameOver: true,
 		},
 		{
 			name: "Error on rounds selection",
 			prompter: &mockPromptSequence{
 				returns: []int{0},
 				errors:  []error{fmt.Errorf("mock error")},
 			},
-			wantGameOver: true,
 		},
 		{
 			name: "Error on move selection",
 			prompter: &mockPromptSequence{
 				returns: []int{0, 0},
 				errors:  []error{nil, fmt.Errorf("mock error")},
 			},
-			wantGameOver: true,
 		},
 		{
 			name: "Invalid round index",
 			prompter: &mockPromptSequence{
 				returns: []int{99, 3}, // Invalid round index, then exit
 				errors:  []error{nil, nil},
 			},
-			wantGameOver: true,
 		},
 	}
 
@@ -398,6 +394,26 @@ func TestParseInt(t *testing.T) {
 			input: "invalid",
 			want:  3,
 		},
+		{
+			name:  "Empty input returns default",
+			input: "",
+			want:  3,
+		},
+		{
+			name:  "Negative number returns default",
+			input: "-1",
+			want:  3,
+		},
+		{
+			name:  "Zero returns default",
+			input: "0",
+			want:  3,
+		},
+		{
+			name:  "Even number returns next odd number",
+			input: "4",
+			want:  5,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {