Skip to content

Commit f06f1f0

Browse files
barroitgitster
authored andcommitted
autocorrect: rename AUTOCORRECT_SHOW to AUTOCORRECT_HINT
AUTOCORRECT_SHOW is ambiguous. Its purpose is to show commands similar to the unknown one and take no other action. Rename it to fit the semantics. Signed-off-by: Jiamu Sun <39@barroit.sh> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent a6e0ccb commit f06f1f0

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

autocorrect.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ static enum autocorrect_mode parse_autocorrect(const char *value)
1212
case 1:
1313
return AUTOCORRECT_IMMEDIATELY;
1414
case 0:
15-
return AUTOCORRECT_SHOW;
15+
return AUTOCORRECT_HINT;
1616
default: /* other random text */
1717
break;
1818
}
@@ -24,7 +24,7 @@ static enum autocorrect_mode parse_autocorrect(const char *value)
2424
else if (!strcmp(value, "immediate"))
2525
return AUTOCORRECT_IMMEDIATELY;
2626
else if (!strcmp(value, "show"))
27-
return AUTOCORRECT_SHOW;
27+
return AUTOCORRECT_HINT;
2828
else
2929
return AUTOCORRECT_DELAY;
3030
}
@@ -49,7 +49,7 @@ void autocorrect_resolve_config(const char *var, const char *value,
4949
conf->delay = git_config_int(var, value, ctx->kvi);
5050

5151
if (!conf->delay)
52-
conf->mode = AUTOCORRECT_SHOW;
52+
conf->mode = AUTOCORRECT_HINT;
5353
else if (conf->delay < 0 || conf->delay == 1)
5454
conf->mode = AUTOCORRECT_IMMEDIATELY;
5555
}

autocorrect.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
struct config_context;
55

66
enum autocorrect_mode {
7-
AUTOCORRECT_SHOW,
7+
AUTOCORRECT_HINT,
88
AUTOCORRECT_NEVER,
99
AUTOCORRECT_PROMPT,
1010
AUTOCORRECT_IMMEDIATELY,

help.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,7 @@ char *help_unknown_cmd(const char *cmd)
674674
; /* still counting */
675675
}
676676

677-
if (cfg.autocorrect.mode != AUTOCORRECT_SHOW && n == 1 &&
677+
if (cfg.autocorrect.mode != AUTOCORRECT_HINT && n == 1 &&
678678
SIMILAR_ENOUGH(best_similarity)) {
679679
char *assumed = xstrdup(main_cmds.names[0]->name);
680680

0 commit comments

Comments
 (0)