fix(generic): save new refresh_token value (#1838)

mjcheetham · web-flow · commit ac11c905af48 · 2025-11-11T04:25:51.000-08:00
Missing the update of single-use-tokens will lead to continuous
re-registration requirement for GCM.

Check is done correctly for new value.
Just the storage step used the old value instead of the new one.
diff --git a/src/shared/Core/GenericHostProvider.cs b/src/shared/Core/GenericHostProvider.cs
@@ -161,7 +161,7 @@ private async Task<ICredential> GetOAuthAccessToken(Uri remoteUri, string userNa
                     // Store new refresh token if we have been given one
                     if (!string.IsNullOrWhiteSpace(refreshResult.RefreshToken))
                     {
-                        Context.CredentialStore.AddOrUpdate(refreshService, refreshToken.Account, refreshToken.Password);
+                        Context.CredentialStore.AddOrUpdate(refreshService, refreshToken.Account, refreshResult.RefreshToken);
                     }
 
                     // Return the new access token

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ private async Task<ICredential> GetOAuthAccessToken(Uri remoteUri, string userNa`
`161`	`161`	`// Store new refresh token if we have been given one`
`162`	`162`	`if (!string.IsNullOrWhiteSpace(refreshResult.RefreshToken))`
`163`	`163`	`{`
`164`		`- Context.CredentialStore.AddOrUpdate(refreshService, refreshToken.Account, refreshToken.Password);`
	`164`	`+ Context.CredentialStore.AddOrUpdate(refreshService, refreshToken.Account, refreshResult.RefreshToken);`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`// Return the new access token`