fix(aws-serverless): Prevent crash in isPromiseAllSettledResult with null/undefined array elements (#19346)

Added a guard against null/undefined elements in
isPromiseAllSettledResult which caused TypeError: Cannot convert
undefined or null to object when captureAllSettledReasons: true and the
Lambda handler returned an array containing nullish values.

closes #19344

Author: chargome

packages/aws-serverless/src/sdk.ts

@@ -44,6 +44,8 @@ export interface WrapperOptions {
 function isPromiseAllSettledResult<T>(result: T[]): boolean {
   return result.every(
     v =>
+      v != null &&
+      typeof v === 'object' &&
       Object.prototype.hasOwnProperty.call(v, 'status') &&
       (Object.prototype.hasOwnProperty.call(v, 'value') || Object.prototype.hasOwnProperty.call(v, 'reason')),
   );

packages/aws-serverless/test/sdk.test.ts

@@ -191,6 +191,30 @@ describe('AWSLambda', () => {
       expect(mockCaptureException).toHaveBeenNthCalledWith(2, error2, expect.any(Function));
       expect(mockCaptureException).toBeCalledTimes(2);
     });
+
+    test('captureAllSettledReasons does not throw on array with null elements', async () => {
+      const handler = () => Promise.resolve([null]);
+      const wrappedHandler = wrapHandler(handler, { captureAllSettledReasons: true });
+      await expect(wrappedHandler(fakeEvent, fakeContext, fakeCallback)).resolves.toEqual([null]);
+      expect(mockCaptureException).toBeCalledTimes(0);
+    });
+
+    test('captureAllSettledReasons does not throw on array with undefined elements', async () => {
+      const handler = () => Promise.resolve([undefined]);
+      const wrappedHandler = wrapHandler(handler, { captureAllSettledReasons: true });
+      await expect(wrappedHandler(fakeEvent, fakeContext, fakeCallback)).resolves.toEqual([undefined]);
+      expect(mockCaptureException).toBeCalledTimes(0);
+    });
+
+    test('captureAllSettledReasons does not throw on mixed array with null and settled results', async () => {
+      const handler = () => Promise.resolve([null, { status: 'rejected', reason: new Error() }]);
+      const wrappedHandler = wrapHandler(handler, { captureAllSettledReasons: true });
+      await expect(wrappedHandler(fakeEvent, fakeContext, fakeCallback)).resolves.toEqual([
+        null,
+        { status: 'rejected', reason: expect.any(Error) },
+      ]);
+      expect(mockCaptureException).toBeCalledTimes(0);
+    });
   });
 
   describe('wrapHandler() on sync handler', () => {