Skip to content

Commit fdddf8c

Browse files
authored
fix: handle stale .vllm-venv in test runner (#829)
* fix: handle stale .vllm-venv in test runner (#828) Add --clear to the uv venv call so a leftover venv from a killed job or incomplete cleanup is replaced instead of causing a hard failure. Fixes #828 * fix: add .*-venv to .gitignore (#828) When CACHE_DIR is unset the test runner creates .vllm-venv in the repo root. Without a gitignore entry this multi-GB directory can be accidentally committed or rsynced. Use a wildcard to cover any future isolated venvs following the same naming pattern.
1 parent 301ca3e commit fdddf8c

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -381,6 +381,7 @@ celerybeat.pid
381381
# Environments
382382
.env
383383
.venv
384+
.*-venv
384385
env/
385386
venv/
386387
ENV/

test/scripts/run_tests_with_ollama_and_vllm.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ if [[ "$WITH_VLLM" == "1" ]]; then
219219
log "Reusing existing vLLM venv at $VLLM_VENV (KEEP_VLLM_VENV=1)"
220220
else
221221
log "Creating isolated vLLM venv at $VLLM_VENV ..."
222-
uv venv "$VLLM_VENV" --python 3.11
222+
uv venv "$VLLM_VENV" --python 3.11 --clear
223223
log "Installing vllm into $VLLM_VENV ..."
224224
uv pip install --python "$VLLM_VENV/bin/python" vllm \
225225
> "$LOGDIR/vllm_install.log" 2>&1 \

0 commit comments

Comments
 (0)