fix: user requests sms in PhoneReauthView

Author: russellwheatley

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/ReauthenticationCoordinator.swift

@@ -48,6 +48,7 @@ public final class ReauthenticationCoordinator {
   public var isReauthenticating = false
   public var reauthContext: ReauthContext?
   public var showingPhoneReauth = false
+  public var showingPhoneReauthAlert = false
 
   private var continuation: CheckedContinuation<Void, Error>?
 
@@ -59,15 +60,21 @@ public final class ReauthenticationCoordinator {
       self.continuation = continuation
       self.reauthContext = context
 
-      // Show different UI based on provider
+      // Show alert first for all providers (including phone)
       if context.providerId == PhoneAuthProviderID {
-        self.showingPhoneReauth = true
+        self.showingPhoneReauthAlert = true
       } else {
         self.isReauthenticating = true
       }
     }
   }
 
+  /// Called when user confirms phone reauth alert
+  public func confirmPhoneReauth() {
+    showingPhoneReauthAlert = false
+    showingPhoneReauth = true
+  }
+
   /// Called when reauthentication completes successfully
   public func reauthCompleted() {
     continuation?.resume()
@@ -84,6 +91,7 @@ public final class ReauthenticationCoordinator {
     continuation = nil
     isReauthenticating = false
     showingPhoneReauth = false
+    showingPhoneReauthAlert = false
     reauthContext = nil
   }
 }

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/PhoneReauthView.swift

@@ -102,22 +102,40 @@ extension PhoneReauthView: View {
             .font(.body)
             .foregroundColor(.secondary)
             .multilineTextAlignment(.center)
-
-          Text(phoneNumber)
-            .font(.headline)
-            .foregroundColor(.primary)
         }
         .padding()
 
         if verificationID == nil {
-          // Send SMS button
-          Button("Send Verification Code") {
-            sendSMS()
+          // Initial state - sending SMS
+          VStack(spacing: 16) {
+            if isLoading {
+              ProgressView()
+                .scaleEffect(1.5)
+                .padding()
+
+              Text("Sending verification code...")
+                .font(.body)
+                .foregroundColor(.secondary)
+
+              Text(phoneNumber)
+                .font(.headline)
+            } else {
+              Text("We'll send a verification code to:")
+                .font(.body)
+                .foregroundColor(.secondary)
+
+              Text(phoneNumber)
+                .font(.headline)
+                .padding(.bottom, 8)
+
+              Button("Send Verification Code") {
+                sendSMS()
+              }
+              .buttonStyle(.borderedProminent)
+              .accessibilityIdentifier("send-verification-code-button")
+            }
           }
-          .buttonStyle(.borderedProminent)
-          .disabled(isLoading)
           .padding()
-          .accessibilityIdentifier("send-verification-code-button")
         } else {
           // Enter verification code
           AuthTextField(
@@ -162,10 +180,6 @@ extension PhoneReauthView: View {
       }
     }
     .errorAlert(error: $error, okButtonLabel: authService.string.okButtonLabel)
-    .onAppear {
-      // Auto-send SMS on appear for better UX
-      sendSMS()
-    }
   }
 }
 

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/ReauthenticationModifier.swift

@@ -22,7 +22,7 @@ struct ReauthenticationModifier: ViewModifier {
 
   func body(content: Content) -> some View {
     content
-      // Alert asking user to reauthenticate
+      // Alert for non-phone providers
       .alert(
         "Authentication Required",
         isPresented: $coordinator.isReauthenticating
@@ -38,7 +38,23 @@ struct ReauthenticationModifier: ViewModifier {
           Text(context.displayMessage)
         }
       }
-      // Sheet for phone reauthentication
+      // Alert for phone provider
+      .alert(
+        "Phone Verification Required",
+        isPresented: $coordinator.showingPhoneReauthAlert
+      ) {
+        Button("Proceed") {
+          coordinator.confirmPhoneReauth()
+        }
+        Button("Cancel", role: .cancel) {
+          coordinator.reauthCancelled()
+        }
+      } message: {
+        if let phoneNumber = coordinator.reauthContext?.phoneNumber {
+          Text("For security, we need to verify your phone number: \(phoneNumber)")
+        }
+      }
+      // Sheet for phone reauthentication (shown after alert confirmation)
       .sheet(isPresented: $coordinator.showingPhoneReauth) {
         if let phoneNumber = coordinator.reauthContext?.phoneNumber {
           PhoneReauthView(