question: how to make Views concrete? (i.e not use Any View)

Author: russellwheatley

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift

@@ -2,8 +2,8 @@
 import SwiftUI
 
 public protocol ExternalAuthProvider {
-  associatedtype ButtonType: View
-  @MainActor var authButton: ButtonType { get }
+  var id: String { get } 
+  @MainActor func authButton() -> AnyView
 }
 
 public protocol GoogleProviderProtocol: ExternalAuthProvider {
@@ -96,6 +96,21 @@ public final class AuthService {
   private var listenerManager: AuthListenerManager?
   private var signedInCredential: AuthCredential?
 
+  private var providers: [ExternalAuthProvider] = []
+  public func register(provider: ExternalAuthProvider) {
+    providers.append(provider)
+  }
+
+  public func renderButtons(spacing: CGFloat = 16) -> AnyView {
+    AnyView(
+      VStack(spacing: spacing) {
+        ForEach(providers, id: \.id) { provider in
+          provider.authButton()
+        }
+      }
+    )
+  }
+
   private var safeGoogleProvider: any GoogleProviderProtocol {
     get throws {
       guard let provider = googleProvider else {

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Strings/Localizable.xcstrings

@@ -1047,6 +1047,9 @@
           }
         }
       }
+    },
+    "Update password" : {
+
     },
     "UpdateEmailAlertMessage" : {
       "comment" : "Alert action message shown before updating email action. Use short/abbreviated translation for 'email' which is less than 15 chars.",

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/AuthPickerView.swift

@@ -28,7 +28,7 @@ extension AuthPickerView: View {
         Text(authService.authenticationFlow == .login ? "Login" : "Sign up")
         VStack { Divider() }
         EmailAuthView()
-        providerButtons()
+        authService.renderButtons()
         VStack { Divider() }
         HStack {
           Text(authService

FirebaseSwiftUI/FirebaseFacebookSwiftUI/Sources/Services/AuthService+Facebook.swift

@@ -0,0 +1,16 @@
+//
+//  AuthService+Facebook.swift
+//  FirebaseUI
+//
+//  Created by Russell Wheatley on 01/05/2025.
+//
+
+import FirebaseAuthSwiftUI
+
+public extension AuthService {
+  @discardableResult
+  func withFacebookSignIn(scopes scopes: [String]? = nil) -> AuthService {
+    facebookProvider = FacebookProviderSwift(scopes: scopes)
+    return self
+  }
+}

FirebaseSwiftUI/FirebaseFacebookSwiftUI/Sources/Services/FacebookProviderSwift.swift

@@ -22,6 +22,7 @@ public enum FacebookProviderError: Error {
 }
 
 public class FacebookProviderSwift: FacebookProviderProtocol {
+  public let id: String = "facebook"
   let scopes: [String]
   let shortName = "Facebook"
   let providerId = "facebook.com"
@@ -34,9 +35,9 @@ public class FacebookProviderSwift: FacebookProviderProtocol {
     rawNonce = CommonUtils.randomNonce()
     shaNonce = CommonUtils.sha256Hash(of: rawNonce)
   }
-
-  @MainActor public var authButton: SignInWithFacebookButton {
-    return SignInWithFacebookButton()
+  
+  @MainActor public func authButton() -> AnyView {
+    AnyView(SignInWithFacebookButton())
   }
 
   @MainActor public func signInWithFacebook(isLimitedLogin: Bool) async throws -> AuthCredential {

FirebaseSwiftUI/FirebaseGoogleSwiftUI/Sources/Services/AuthService+Google.swift

@@ -8,12 +8,11 @@
 import FirebaseAuthSwiftUI
 
 public extension AuthService {
-
   @discardableResult
-  public func withGoogleSignIn() -> AuthService {
+  func withGoogleSignIn(scopes scopes: [String]? = nil) -> AuthService {
     let clientID = auth.app?.options.clientID ?? ""
-    self.googleProvider = GoogleProviderSwift(clientID: clientID)
+    googleProvider = GoogleProviderSwift(scopes: scopes, clientID: clientID)
+    register(provider: googleProvider!)
     return self
   }
-
 }

FirebaseSwiftUI/FirebaseGoogleSwiftUI/Sources/Services/GoogleProviderSwift.swift

@@ -16,6 +16,7 @@ public enum GoogleProviderError: Error {
 }
 
 public class GoogleProviderSwift: @preconcurrency GoogleProviderProtocol {
+  public let id: String = "google"
   let scopes: [String]
   let shortName = "Google"
   let providerId = "google.com"
@@ -25,12 +26,12 @@ public class GoogleProviderSwift: @preconcurrency GoogleProviderProtocol {
     self.clientID = clientID
   }
 
-  @MainActor public var authButton: GoogleSignInButton {
-    return GoogleSignInButton {
+  @MainActor public func authButton() -> AnyView {
+    AnyView(GoogleSignInButton {
       Task {
         try await self.signInWithGoogle(clientID: self.clientID)
       }
-    }
+    })
   }
 
   @MainActor public func signInWithGoogle(clientID: String) async throws -> AuthCredential {

FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/PhoneAuthProviderSwift.swift

@@ -5,13 +5,12 @@ import SwiftUI
 public typealias VerificationID = String
 
 public class PhoneAuthProviderSwift: @preconcurrency PhoneAuthProviderProtocol {
-
-  public var authButton: Button<Text> {
-    // TODO: implement me
-    return Button("Phone", action: { })
-  }
-
+  public let id: String = "phone"
   public init() {}
+  
+  @MainActor public func authButton() -> AnyView {
+    AnyView(Text("phone button TODO"))
+  }
 
   @MainActor public func verifyPhoneNumber(phoneNumber: String) async throws -> VerificationID {
     return try await withCheckedThrowingContinuation { continuation in

Package.swift

@@ -277,7 +277,7 @@ let package = Package(
       dependencies: [
         "FirebaseAuthSwiftUI",
         "GoogleSignIn",
-        .product(name: "GoogleSignInSwift", package: "GoogleSignIn")
+        .product(name: "GoogleSignInSwift", package: "GoogleSignIn"),
       ],
       path: "FirebaseSwiftUI/FirebaseGoogleSwiftUI/Sources"
     ),

samples/swiftui/FirebaseSwiftUIExample/FirebaseSwiftUIExample/FirebaseSwiftUIExampleApp.swift

@@ -95,17 +95,15 @@ struct ContentView: View {
     let phoneAuthProvider = PhoneAuthProviderSwift()
     authService = AuthService(
       configuration: configuration,
-      googleProvider: nil,
       facebookProvider: facebookProvider,
       phoneAuthProvider: phoneAuthProvider
     )
-      // Transition to this api
-      .withGoogleSignIn()
+    // Transition to this api
+    .withGoogleSignIn()
   }
 
   var body: some View {
     AuthPickerView {
-      SignInWithGoogleButton()
       SignInWithFacebookButton()
       PhoneAuthButtonView()
     }.environment(authService)