Force client to use relative URL to ease integration with Docker

Author: frankie567

fief_client/client.py

@@ -3,7 +3,7 @@
 import uuid
 from enum import Enum
 from typing import Any, Dict, List, Mapping, Optional, Tuple, TypedDict, Union
-from urllib.parse import urlencode
+from urllib.parse import urlencode, urlsplit
 
 import httpx
 from httpx._types import CertTypes, VerifyTypes
@@ -237,7 +237,18 @@ def __init__(
     def _get_endpoint_url(
         self, openid_configuration: Dict[str, Any], field: str
     ) -> str:
-        return openid_configuration[field]
+        """
+        Return the specified endpoint from OpenID configuration.
+
+        We only retain the path here, as the host might not be relevant in our context.
+
+        Typically, we might be in a Docker environment where the client app has to make
+        request to the Fief server through Docker networking. Therefore, we do not
+        want the client to use the absolute URL generated by OpenID Configuration, but
+        rather stick to the host specified on the client configuration.
+        """
+        splitted_url = urlsplit(openid_configuration[field])
+        return splitted_url.path
 
     def _auth_url(
         self,

tests/test_client.py

@@ -164,7 +164,7 @@ def test_authorization_url(
         )
         assert (
             authorize_url
-            == f"https://bretagne.fief.dev/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
+            == f"/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
         )
 
         assert mock_api_requests.calls.last is not None
@@ -225,7 +225,7 @@ async def test_authorization_url_async(
         )
         assert (
             authorize_url
-            == f"https://bretagne.fief.dev/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
+            == f"/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
         )
 
         assert mock_api_requests.calls.last is not None