Fix auth_url and logout_url should return absolute URL #14

Author: frankie567

fief_client/client.py

@@ -235,20 +235,27 @@ def __init__(
         self.cert = cert
 
     def _get_endpoint_url(
-        self, openid_configuration: Dict[str, Any], field: str
+        self,
+        openid_configuration: Dict[str, Any],
+        field: str,
+        *,
+        absolute: bool = False,
     ) -> str:
         """
         Return the specified endpoint from OpenID configuration.
 
-        We only retain the path here, as the host might not be relevant in our context.
+        If `absolute` is `False`, we only retain the path,
+        as the host might is not always relevant in our context.
 
         Typically, we might be in a Docker environment where the client app has to make
         request to the Fief server through Docker networking. Therefore, we do not
         want the client to use the absolute URL generated by OpenID Configuration, but
         rather stick to the host specified on the client configuration.
         """
-        splitted_url = urlsplit(openid_configuration[field])
-        return splitted_url.path
+        if not absolute:
+            splitted_url = urlsplit(openid_configuration[field])
+            return splitted_url.path
+        return openid_configuration[field]
 
     def _auth_url(
         self,
@@ -285,7 +292,7 @@ def _auth_url(
             params = {**params, **extras_params}
 
         authorization_endpoint = self._get_endpoint_url(
-            openid_configuration, "authorization_endpoint"
+            openid_configuration, "authorization_endpoint", absolute=True
         )
         return f"{authorization_endpoint}?{urlencode(params)}"
 

tests/test_client.py

@@ -164,7 +164,7 @@ def test_authorization_url(
         )
         assert (
             authorize_url
-            == f"/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
+            == f"https://bretagne.fief.dev/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
         )
 
         assert mock_api_requests.calls.last is not None
@@ -225,7 +225,7 @@ async def test_authorization_url_async(
         )
         assert (
             authorize_url
-            == f"/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
+            == f"https://bretagne.fief.dev/authorize?response_type=code&client_id=CLIENT_ID&redirect_uri=https%3A%2F%2Fwww.bretagne.duchy%2Fcallback{expected_params}"
         )
 
         assert mock_api_requests.calls.last is not None