Skip to content

Commit d1dba8b

Browse files
Jiayue Baofacebook-github-bot
authored andcommitted
TODOs cleanup
Summary: Clean up out-of-date TODOs; Mark the task to still valid TODO. Reviewed By: haowu14 Differential Revision: D55090262 fbshipit-source-id: cbc9d7bc041b12c0378f92c13c8e5115e869aa1c
1 parent 6a1e9f7 commit d1dba8b

3 files changed

Lines changed: 1 addition & 3 deletions

File tree

cachelib/allocator/ChainedHashTable.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,6 @@ class ChainedHashTable {
559559
return !(*this == other);
560560
}
561561

562-
// TODO(jiayueb): change to return ReadHandle after fixing all the breaks
563562
const Handle& asHandle() { return curr(); }
564563

565564
// reset the Iterator to begin of container

cachelib/navy/common/Device.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1129,7 +1129,7 @@ folly::File openCacheFile(const std::string& fileName,
11291129
}
11301130

11311131
#ifndef MISSING_FALLOCATE
1132-
// TODO(jiayueb): make allocate flag user configurable and migrate the
1132+
// TODO T182882306: make allocate flag user configurable and migrate the
11331133
// existing use cases
11341134
// fallocate the file if requesting a larger file size and allocate flag is
11351135
// set

cachelib/rust/src/cachelib.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ std::unique_ptr<LruItemHandle> find_item(const LruAllocator& cache,
179179
folly::StringPiece key) {
180180
auto item = const_cast<LruAllocator&>(cache).find(key);
181181
if (item) {
182-
// TODO(jiayueb) remove toWriteHandle() after finishing R/W handle migration
183182
return std::make_unique<LruItemHandle>(std::move(item).toWriteHandle());
184183
} else {
185184
return std::unique_ptr<LruItemHandle>();

0 commit comments

Comments
 (0)