Remove unused exception parameter from cachelib/navy/serialization/tests/RecordIOTest.cpp

Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: palmje

Differential Revision: D55092111

fbshipit-source-id: 95ca871a34ea6b1720038e8acd477703193b0b67

Author: r-barnes

cachelib/navy/serialization/tests/RecordIOTest.cpp

@@ -109,7 +109,7 @@ TEST(RecordIO, MemoryDevice) {
         memset(wbuf->writableData(), testChar, testSize);
         try {
           rw->writeRecord(std::move(wbuf));
-        } catch (std::logic_error& e) {
+        } catch (std::logic_error&) {
           writeFailed = true;
           failedIter = j;
           break;
@@ -127,7 +127,7 @@ TEST(RecordIO, MemoryDevice) {
           for (uint32_t k = 0; k < testSize; k++) {
             EXPECT_EQ(data[k], testChar);
           }
-        } catch (std::logic_error& e) {
+        } catch (std::logic_error&) {
           readFailed = true;
           EXPECT_EQ(j, failedIter);
           break;
@@ -180,7 +180,7 @@ TEST(RecordIO, MemoryDeviceVariousPayloads) {
           memset(wbuf->writableData(), testChar, testSize);
           try {
             rw->writeRecord(std::move(wbuf));
-          } catch (std::logic_error& e) {
+          } catch (std::logic_error&) {
             failedIter = j;
             break;
             /* ignore */
@@ -196,7 +196,7 @@ TEST(RecordIO, MemoryDeviceVariousPayloads) {
             for (uint32_t k = 0; k < testSize; k++) {
               EXPECT_EQ(data[k], testChar);
             }
-          } catch (std::logic_error& e) {
+          } catch (std::logic_error&) {
             // read should fail when we cannot write beyond the metadataSize
             EXPECT_EQ(j, failedIter);
             break;

cachelib/shm/tests/test_shm_manager.cpp

@@ -50,14 +50,14 @@ class ShmManagerTest : public ShmTestBase {
   void TearDown() final {
     try {
       clearAllSegments();
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       // ignore
     }
 
     try {
       facebook::cachelib::util::removePath(cacheDir);
       // make sure nothing exists at the end
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       // ignore
     }
   }