Refer to mentor when code does not match criteria

Author: Karlo Soriano

lib/analyzers/acronym/analyze.rb

@@ -10,6 +10,8 @@ def analyze!
       approve! if approve_without_comment?
 
       approve!(:use_shorthand_block_syntax) if solution.uses_method_chain_with_block?
+
+      refer_to_mentor!
     end
 
     private
@@ -24,5 +26,11 @@ def approve!(msg = nil)
 
       raise FinishedFlowControlException
     end
+
+    def refer_to_mentor!
+      self.status = :refer_to_mentor
+
+      raise FinishedFlowControlException
+    end
   end
 end

lib/analyzers/acronym/representation.rb

@@ -42,8 +42,7 @@ def uses_method_chain_with_block?
           type: :block,
           method_name: :map,
           chained?: true,
-          arguments: s(:args, s(:arg, :word)),
-          body: s(:send, s(:lvar, :word), :chr)
+          arguments: s(:args, s(:arg, :word))
         },
         {
           method_name: :map,
@@ -57,6 +56,10 @@ def uses_method_chain_with_block?
           receiver: s(:lvar, :words),
           chained?: true,
           arguments: [{ to_ast: s(:str, "-") }, { to_ast: s(:str, " ") }]
+        },
+        {
+          method_name: :chr,
+          receiver: s(:lvar, :word)
         }
       ]
 
@@ -127,7 +130,7 @@ def matches?(body, matchers, types = [:send])
 
     def node_matches?(node, matcher)
       matcher.
-        map do |criteria|
+        all? do |criteria|
           key, expected_value = *criteria
           criteria_value = node.send(key)
 
@@ -139,8 +142,7 @@ def node_matches?(node, matcher)
           else
             criteria_value == expected_value
           end
-        end.
-        all?
+        end
     end
   end
 end

test/exercises/acronym_test.rb

@@ -41,6 +41,30 @@ def self.abbreviate(words)
     assert_equal [], results[:comments]
   end
 
+  def test_refers_to_mentor_with_method_not_matching
+    source = %q{
+      class Acronym
+        def self.abbreviate(words)
+          test.words.tr('-', ' ').split.map(&:chr).join.upcase
+        end
+      end
+    }
+    results = Acronym::Analyze.(source)
+    assert_equal :refer_to_mentor, results[:status]
+  end
+
+  def test_refers_to_mentor_with_random_method_body
+    source = %q{
+      class Acronym
+        def self.abbreviate(words)
+          anything_here.123.456.test_method
+        end
+      end
+    }
+    results = Acronym::Analyze.(source)
+    assert_equal :refer_to_mentor, results[:status]
+  end
+
   def test_scan_with_any_regex_passes
     source = %q{
       class Acronym