Split our conceptual analysis and static analysis

Author: iHiD

lib/analyzer.rb

@@ -21,8 +21,10 @@
 require_relative 'analyze_solution'
 
 require_relative 'analyzers/exercise_analyzer'
+require_relative "analyzers/solution_representation"
 EXERCISES.each do |exercise|
   require_relative "analyzers/#{exercise}/analyze"
+  require_relative "analyzers/#{exercise}/representation"
 end
 
 module Analyzer

lib/analyzers/exercise_analyzer.rb

@@ -1,5 +1,4 @@
 class ExerciseAnalyzer
-  include SA::InlineHelpers
 
   # This is just flow-control for quickly exiting the
   # analysis. We probably don't want to do things this
@@ -8,9 +7,11 @@ class FinishedFlowControlException < RuntimeError
   end
 
   def initialize(code_to_analyze)
-    @code_to_analyze = code_to_analyze
     @status = nil
     @comments = []
+
+    solution_class = "#{self.class.name.split("::").first}::Representation".constantize
+    @solution = solution_class.new(code_to_analyze)
   end
 
   def call
@@ -29,19 +30,8 @@ def results
   end
 
   private
-  attr_reader :code_to_analyze
+  attr_reader :solution
 
   protected
   attr_accessor :status, :comments
-
-  def root_node
-    @root_node ||= begin
-      buffer        = Parser::Source::Buffer.new(nil)
-      buffer.source = code_to_analyze
-      builder       = RuboCop::AST::Builder.new
-      parser        = Parser::CurrentRuby.new(builder)
-
-      parser.parse(buffer)
-    end
-  end
 end

lib/analyzers/solution_representation.rb

@@ -0,0 +1,70 @@
+class SolutionRepresentation
+  include Mandate
+  include SA::InlineHelpers
+
+  def initialize(code_to_analyze)
+    @code_to_analyze = code_to_analyze
+  end
+
+  # REFACTOR: This could be refactored to strip blank
+  # lines and then use each_cons(2).
+  def indentation_is_sensible?
+    previous_line = nil
+    code_to_analyze.lines.each do |line|
+      # If the previous line or this line is
+      # just a whitespace line, don't consider it
+      # when checking for indentation
+      unless previous_line == nil ||
+             previous_line =~ /^\s*\n*$/ ||
+             line =~ /^\s*\n*$/
+
+        previous_line_lspace = previous_line[/^ */].size
+        line_lspace = line[/^ */].size
+
+        return false if (previous_line_lspace - line_lspace).abs > 2
+      end
+
+      previous_line = line
+    end
+
+    true
+  end
+
+  def has_target_module?
+    target_module
+  end
+
+  def has_target_method?
+    target_method
+  end
+
+  # MOVE BELOW HERE TO PRIVATE
+
+  memoize
+  def target_method
+    SA::Helpers.extract_module_method(target_module, "two_fer")
+  end
+
+  private
+  attr_reader :code_to_analyze
+
+  memoize
+  def target_module
+    SA::Helpers.extract_module_or_class(root_node, "TwoFer")
+  end
+
+  def default_argument_value
+    default_argument.children[0]
+  end
+
+  def root_node
+    @root_node ||= begin
+      buffer        = Parser::Source::Buffer.new(nil)
+      buffer.source = code_to_analyze
+      builder       = RuboCop::AST::Builder.new
+      parser        = Parser::CurrentRuby.new(builder)
+
+      parser.parse(buffer)
+    end
+  end
+end