refactor: remove redundant HUD tests for volume key presses and formatting

Author: euxx

VolumeGridTests/HUDTests.swift

@@ -324,294 +324,6 @@ final class HUDScenarioTests: XCTestCase {
         super.tearDown()
     }
 
-    // MARK: - Volume Key Press Scenarios
-
-    func testHUDShowsWhenVolumeKeyPressed() {
-        let expectation = XCTestExpectation(
-            description: "HUD should be visible after volume key press")
-        mockSystemEventMonitor?.simulateVolumeKeyPress(keyCode: 0)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDShowsWhenMuteKeyPressed() {
-        let expectation = XCTestExpectation(
-            description: "HUD should be visible after mute key press")
-
-        let hudDisplayed = {
-            expectation.fulfill()
-        }
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            hudDisplayed()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDShowsWhenIncreaseVolumeKeyPressed() {
-        let expectation = XCTestExpectation(
-            description: "HUD should display when volume increase key is pressed")
-
-        mockSystemEventMonitor?.simulateVolumeKeyPress(keyCode: 0)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.15) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDShowsWhenDecreaseVolumeKeyPressed() {
-        let expectation = XCTestExpectation(
-            description: "HUD should display when volume decrease key is pressed")
-
-        mockSystemEventMonitor?.simulateVolumeKeyPress(keyCode: 1)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.15) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDShowsWhenMuteKeyPressedAtZeroVolume() {
-        let expectation = XCTestExpectation(
-            description: "HUD should display when mute key is pressed even when volume is at 0")
-
-        let mutedEvent = HUDEvent(volumeScalar: 0.0, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(mutedEvent.volumeScalar, 0.0)
-
-        mockSystemEventMonitor?.simulateVolumeKeyPress(keyCode: 7)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.15) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testMuteStateTransitionFromZeroVolume() {
-        let expectation = XCTestExpectation(
-            description: "When volume is 0 and mute state changes, HUD should still be shown")
-
-        let zeroMutedEvent = HUDEvent(
-            volumeScalar: 0.0, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(zeroMutedEvent.volumeScalar, 0.0)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testVolumeChangeFromZeroToNonZero() {
-        let expectation = XCTestExpectation(
-            description: "HUD should display when volume increases from 0")
-
-        let zeroEvent = HUDEvent(volumeScalar: 0.0, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(zeroEvent.volumeScalar, 0.0)
-
-        let nonZeroEvent = HUDEvent(volumeScalar: 0.3, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(nonZeroEvent.volumeScalar, 0.3)
-        XCTAssertNotEqual(zeroEvent.volumeScalar, nonZeroEvent.volumeScalar)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDEventEmittedWhenVolumeIsZero() {
-        let expectation = XCTestExpectation(
-            description: "HUD event should be emitted with zero volume scalar")
-
-        let event = HUDEvent(volumeScalar: 0.0, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(event.volumeScalar, 0.0)
-        XCTAssertEqual(event.deviceName, "Speaker")
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testRapidVolumeKeyPresses() {
-        let expectation = XCTestExpectation(
-            description: "Rapid consecutive volume key presses should show correct HUD values")
-
-        let volumes: [CGFloat] = [0.3, 0.4, 0.5, 0.6, 0.7]
-        var events: [HUDEvent] = []
-
-        for volume in volumes {
-            let event = HUDEvent(volumeScalar: volume, deviceName: "Speaker", isUnsupported: false)
-            events.append(event)
-            XCTAssertEqual(event.volumeScalar, volume)
-        }
-
-        XCTAssertEqual(events.last?.volumeScalar, 0.7)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.2) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testDebounceDoesNotDisplayIntermediateValues() {
-        let expectation = XCTestExpectation(
-            description:
-                "HUD events should not show intermediate values that differ from what was pressed")
-
-        let event1 = HUDEvent(volumeScalar: 0.19, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(event1.volumeScalar, 0.19)
-
-        let event2 = HUDEvent(volumeScalar: 0.22, deviceName: "Speaker", isUnsupported: false)
-        let event3 = HUDEvent(volumeScalar: 0.25, deviceName: "Speaker", isUnsupported: false)
-
-        XCTAssert(event3.volumeScalar > event2.volumeScalar)
-        XCTAssert(event2.volumeScalar > event1.volumeScalar)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    // MARK: - Output Device Switch
-
-    func testHUDShowsWhenOutputDeviceSwitched() {
-        let expectation = XCTestExpectation(
-            description: "HUD should be visible when output device is switched")
-
-        NotificationCenter.default.post(
-            name: NSNotification.Name("AudioDeviceChanged"), object: nil)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDDisplaysNewDeviceNameAfterSwitch() {
-        let expectation = XCTestExpectation(
-            description: "HUD should display new device name after switching")
-        let newDeviceName = "External Speakers"
-
-        mockAudioDeviceManager?.setDefaultOutputDevice(name: newDeviceName)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.15) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDUpdatesWhenMultipleDevicesAvailable() {
-        let expectation = XCTestExpectation(
-            description: "HUD should update when switching between multiple devices")
-
-        mockAudioDeviceManager?.addDevice(name: "Internal Speaker")
-        mockAudioDeviceManager?.addDevice(name: "External Speaker")
-        mockAudioDeviceManager?.switchToDevice(name: "External Speaker")
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    // MARK: - Volume Change
-
-    func testHUDShowsWhenVolumeChanges() {
-        let expectation = XCTestExpectation(
-            description: "HUD should be visible when volume changes")
-
-        _ = HUDEvent(volumeScalar: 0.75, deviceName: "Test Speaker", isUnsupported: false)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDDisplaysCorrectVolumeLevel() {
-        let expectation = XCTestExpectation(description: "HUD should display correct volume level")
-        let testVolume: CGFloat = 0.65
-
-        let volumeEvent = HUDEvent(
-            volumeScalar: testVolume, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(volumeEvent.volumeScalar, testVolume)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDShowsWhenVolumeGoesToZero() {
-        let expectation = XCTestExpectation(
-            description: "HUD should show when volume goes to zero (mute)")
-
-        let muteEvent = HUDEvent(volumeScalar: 0.0, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(muteEvent.volumeScalar, 0.0)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDShowsWhenVolumeGoesToMaximum() {
-        let expectation = XCTestExpectation(
-            description: "HUD should show when volume reaches maximum")
-
-        let maxVolumeEvent = HUDEvent(
-            volumeScalar: 1.0, deviceName: "Speaker", isUnsupported: false)
-        XCTAssertEqual(maxVolumeEvent.volumeScalar, 1.0)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
-    func testHUDUpdatesWithIncrementalVolumeChanges() {
-        let expectation = XCTestExpectation(
-            description: "HUD should update with incremental volume changes")
-
-        let volumes: [CGFloat] = [0.0, 0.25, 0.5, 0.75, 1.0]
-        var updateCount = 0
-
-        for volume in volumes {
-            let event = HUDEvent(volumeScalar: volume, deviceName: "Speaker", isUnsupported: false)
-            XCTAssertEqual(event.volumeScalar, volume)
-            updateCount += 1
-        }
-
-        XCTAssertEqual(updateCount, volumes.count)
-
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            expectation.fulfill()
-        }
-
-        wait(for: [expectation], timeout: 1.0)
-    }
-
     // MARK: - Combined Scenarios
 
     func testHUDShowsForAllThreeScenarios() {

VolumeGridTests/LaunchAtLoginControllerTests.swift

@@ -37,15 +37,6 @@ final class LaunchAtLoginControllerTests: XCTestCase {
 
     // MARK: - isEnabled() Tests
 
-    func testIsEnabledReturnsBool() {
-        let _ = mockController.isEnabled()
-    }
-
-    func testIsEnabledCallableMultipleTimes() {
-        let _ = mockController.isEnabled()
-        let _ = mockController.isEnabled()
-    }
-
     func testIsEnabledReturnsInitialFalse() {
         XCTAssertFalse(mockController.isEnabled())
     }