fix(extension): validate threshold config values as numbers; guard updateStatusBar in rate-limit handler

getConfig: coerce threshold.warning/critical to Number with isFinite fallback
so non-numeric user config values (e.g. strings) don't produce NaN in
comparisons, silently breaking color indicators.

updateStatusBar in RATE_LIMIT catch block: wrap in try/catch so a failure
there doesn't escape as an unhandled promise rejection.

Also add tests/extension.test.js (14 tests) covering:
- formatTimestamp: same-day vs different-day, zero-padding
- getConfig: numeric coercion, NaN fallback, warning > critical clamping
- buildTooltip: unlimited, rate-limited, overage conditions

Introduce tests/setup.js (Module._resolveFilename patch) + tests/__mocks__/vscode.js
to redirect require('vscode') to a local mock for the Node test environment.

Author: euxx

src/extension.js

@@ -102,7 +102,11 @@ async function refresh(promptSignIn = false, isManual = false) {
     } else if (code === 'RATE_LIMIT') {
       if (lastData) {
         // Keep last data but mark tooltip
-        updateStatusBar(lastData, true);
+        try {
+          updateStatusBar(lastData, true);
+        } catch {
+          showError('Rate limited');
+        }
       } else {
         showError('Rate limited');
       }
@@ -274,8 +278,11 @@ function clearTimer() {
 
 function getConfig() {
   const cfg = vscode.workspace.getConfiguration('githubCopilotUsage');
-  const warning = cfg.get('threshold.warning', 75);
-  const critical = cfg.get('threshold.critical', 90);
+  const rawWarning = cfg.get('threshold.warning', 75);
+  const rawCritical = cfg.get('threshold.critical', 90);
+  // Coerce to number and fall back to defaults if non-numeric (e.g. user entered a string)
+  const warning = Number.isFinite(Number(rawWarning)) ? Number(rawWarning) : 75;
+  const critical = Number.isFinite(Number(rawCritical)) ? Number(rawCritical) : 90;
   return {
     refreshIntervalMinutes: cfg.get('refreshIntervalMinutes', 5),
     thresholdEnabled: cfg.get('threshold.enabled', true),
@@ -285,4 +292,4 @@ function getConfig() {
   };
 }
 
-module.exports = { activate, deactivate };
+module.exports = { activate, deactivate, formatTimestamp, getConfig, buildTooltip };

tests/__mocks__/vscode.js

@@ -0,0 +1,69 @@
+'use strict';
+
+/**
+ * Minimal vscode mock for Vitest.
+ * No vi.fn() usage — this file loads in a plain Node context before test globals.
+ */
+
+class MarkdownString {
+  constructor(value = '') {
+    this.value = value;
+    this.isTrusted = false;
+  }
+  appendText(text) {
+    this.value += text;
+    return this;
+  }
+  appendMarkdown(md) {
+    this.value += md;
+    return this;
+  }
+}
+
+class ThemeColor {
+  constructor(id) {
+    this.id = id;
+  }
+}
+
+const StatusBarAlignment = { Left: 1, Right: 2 };
+
+const workspace = {
+  getConfiguration: () => ({ get: (_key, defaultValue) => defaultValue }),
+  onDidChangeConfiguration: () => ({ dispose: () => {} }),
+};
+
+const window = {
+  createStatusBarItem: () => ({
+    show: () => {},
+    hide: () => {},
+    dispose: () => {},
+    text: '',
+    tooltip: undefined,
+    color: undefined,
+    command: undefined,
+  }),
+};
+
+const authentication = {
+  getSession: () => Promise.resolve(null),
+};
+
+const commands = {
+  registerCommand: () => ({ dispose: () => {} }),
+};
+
+const extensions = {
+  getExtension: () => null,
+};
+
+module.exports = {
+  MarkdownString,
+  ThemeColor,
+  StatusBarAlignment,
+  workspace,
+  window,
+  authentication,
+  commands,
+  extensions,
+};

tests/extension.test.js

@@ -0,0 +1,133 @@
+'use strict';
+
+const { formatTimestamp, getConfig, buildTooltip } = require('../src/extension');
+
+// ---------------------------------------------------------------------------
+// formatTimestamp
+// ---------------------------------------------------------------------------
+
+describe('formatTimestamp', () => {
+  it('returns HH:mm:ss only when the date is today', () => {
+    const now = new Date();
+    const result = formatTimestamp(now);
+    // Should match HH:mm:ss (no date prefix)
+    expect(result).toMatch(/^\d{2}:\d{2}:\d{2}$/);
+  });
+
+  it('returns YYYY-MM-DD HH:mm:ss when the date is a different day', () => {
+    const past = new Date('2025-01-15T09:05:03');
+    const result = formatTimestamp(past);
+    expect(result).toBe('2025-01-15 09:05:03');
+  });
+
+  it('zero-pads single-digit hours, minutes, seconds', () => {
+    const past = new Date('2024-03-07T01:02:03');
+    const result = formatTimestamp(past);
+    expect(result).toBe('2024-03-07 01:02:03');
+  });
+});
+
+// ---------------------------------------------------------------------------
+// getConfig – numeric coercion and clamping (tests the NaN fix)
+// ---------------------------------------------------------------------------
+
+describe('getConfig', () => {
+  function mockCfg(values) {
+    const vscode = require('vscode');
+    vscode.workspace.getConfiguration = () => ({
+      get: (key, defaultValue) => (key in values ? values[key] : defaultValue),
+    });
+  }
+
+  afterEach(() => {
+    // Restore default: always returns the default value
+    const vscode = require('vscode');
+    vscode.workspace.getConfiguration = () => ({ get: (_key, def) => def });
+  });
+
+  it('returns numeric thresholds from valid config', () => {
+    mockCfg({ 'threshold.warning': 60, 'threshold.critical': 85 });
+    const cfg = getConfig();
+    expect(cfg.thresholdWarning).toBe(60);
+    expect(cfg.thresholdCritical).toBe(85);
+  });
+
+  it('falls back to defaults when threshold values are non-numeric strings', () => {
+    mockCfg({ 'threshold.warning': 'off', 'threshold.critical': 'off' });
+    const cfg = getConfig();
+    // Both fall back to defaults (75, 90)
+    expect(cfg.thresholdWarning).toBe(75);
+    expect(cfg.thresholdCritical).toBe(90);
+  });
+
+  it('falls back to default 90 for critical when only critical is a string', () => {
+    mockCfg({ 'threshold.warning': 70, 'threshold.critical': 'invalid' });
+    const cfg = getConfig();
+    expect(cfg.thresholdCritical).toBe(90);
+    expect(cfg.thresholdWarning).toBe(70); // valid warning, and 70 < 90
+  });
+
+  it('clamps warning to at most critical when warning > critical', () => {
+    mockCfg({ 'threshold.warning': 95, 'threshold.critical': 80 });
+    const cfg = getConfig();
+    expect(cfg.thresholdWarning).toBe(80); // clamped to critical
+    expect(cfg.thresholdCritical).toBe(80);
+  });
+
+  it('accepts numeric-string values by coercing them', () => {
+    mockCfg({ 'threshold.warning': '60', 'threshold.critical': '85' });
+    const cfg = getConfig();
+    expect(cfg.thresholdWarning).toBe(60);
+    expect(cfg.thresholdCritical).toBe(85);
+  });
+});
+
+// ---------------------------------------------------------------------------
+// buildTooltip
+// ---------------------------------------------------------------------------
+
+describe('buildTooltip', () => {
+  const BASE_DATA = {
+    plan: 'Pro',
+    unlimited: false,
+    noData: false,
+    used: 90,
+    quota: 300,
+    usedPct: 30,
+    overageEnabled: false,
+    overageUsed: 0,
+    resetDate: new Date('2026-04-01T00:00:00Z'),
+  };
+
+  it('shows plan name and used/quota/pct for normal quota', () => {
+    const md = buildTooltip(BASE_DATA, false);
+    expect(md.value).toContain('Pro');
+    expect(md.value).toContain('90 / 300 (30%)');
+  });
+
+  it('shows Unlimited for unlimited plan', () => {
+    const md = buildTooltip({ ...BASE_DATA, unlimited: true }, false);
+    expect(md.value).toContain('Unlimited');
+  });
+
+  it('includes rate-limit notice when isRateLimited is true', () => {
+    const md = buildTooltip(BASE_DATA, true);
+    expect(md.value).toContain('Rate limited');
+  });
+
+  it('does not include rate-limit notice when isRateLimited is false', () => {
+    const md = buildTooltip(BASE_DATA, false);
+    expect(md.value).not.toContain('Rate limited');
+  });
+
+  it('includes overage count when overageEnabled and overageUsed > 0', () => {
+    const data = { ...BASE_DATA, overageEnabled: true, overageUsed: 5 };
+    const md = buildTooltip(data, false);
+    expect(md.value).toContain('Overage: 5 requests');
+  });
+
+  it('omits overage section when overageUsed is 0', () => {
+    const md = buildTooltip(BASE_DATA, false);
+    expect(md.value).not.toContain('Overage');
+  });
+});

tests/setup.js

@@ -0,0 +1,20 @@
+'use strict';
+
+/**
+ * Redirect `require('vscode')` to the test mock before any test module loads.
+ * This patches Node's module resolver so that all require('vscode') calls in
+ * source files and test files resolve to our local mock during testing.
+ */
+
+const Module = require('module');
+const path = require('path');
+
+const mockPath = path.resolve(__dirname, '__mocks__/vscode.js');
+const originalResolveFilename = Module._resolveFilename.bind(Module);
+
+Module._resolveFilename = function (request, ...args) {
+  if (request === 'vscode') {
+    return mockPath;
+  }
+  return originalResolveFilename(request, ...args);
+};

vitest.config.mjs

@@ -4,5 +4,6 @@ export default defineConfig({
   test: {
     globals: true,
     environment: 'node',
+    setupFiles: ['./tests/setup.js'],
   },
 });