Skip to content

Commit ce4155b

Browse files
committed
Fix JS error when trying to replace a tag
Fixes #13 Also: - Improved some UI elements to better fit with Craft 3.4 - Added automatic slug generation when creating a tag
1 parent 8f57073 commit ce4155b

4 files changed

Lines changed: 32 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
## 1.0.7 - 2020-04-15
2+
### Improved
3+
- Improved some UI elements to better fit with Craft 3.4
4+
- Added automatic slug generation when creating a tag
5+
6+
### Fixed
7+
- Fix JS error when trying to replace a tag (Fixes #13)
8+
19
## 1.0.6 - 2020-01-15
210
### Fixed
311
- Fix issue with pgsql when usage column is enabled

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "ether/tags",
33
"description": "A tag manager for Craft 3",
44
"type": "craft-plugin",
5-
"version": "1.0.6",
5+
"version": "1.0.7",
66
"keywords": [
77
"craft",
88
"cms",

src/templates/_edit.twig

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,16 @@
6969
</li>
7070
{% endif %}
7171
</ul>
72+
{% if tag.id %}
73+
<hr>
74+
<ul>
75+
<li>
76+
<a id="delete-btn" class="error">
77+
{{ 'Delete'|t('app') }}
78+
</a>
79+
</li>
80+
</ul>
81+
{% endif %}
7282
</div>
7383
</div>
7484
{% endblock %}
@@ -105,7 +115,7 @@
105115

106116
{% block details %}
107117
<div id="settings" class="meta">
108-
{% if tag.id %}
118+
{#{% if tag.id %}
109119
<div class="first">
110120
<div class="value flex">
111121
<div class="flex-grow"></div>
@@ -123,7 +133,7 @@
123133
</div>
124134
</div>
125135
</div>
126-
{% endif %}
136+
{% endif %}#}
127137

128138
{{ forms.textField({
129139
label: 'Slug'|t('app'),
@@ -134,7 +144,8 @@
134144
autocapitalize: false,
135145
value: tag.slug,
136146
placeholder: 'Enter slug'|t('app'),
137-
errors: (tag.getErrors('slug')|merge(tag.getErrors('uri')))
147+
errors: (tag.getErrors('slug')|merge(tag.getErrors('uri'))),
148+
first: true
138149
}) }}
139150
</div>
140151

@@ -151,3 +162,11 @@
151162
</div>
152163
{% endif %}
153164
{% endblock %}
165+
166+
{% if not tag.slug %}
167+
{% js %}
168+
window.slugGenerator = new Craft.SlugGenerator('#title', '#slug', {
169+
charMap: {{ craft.cp.getAsciiCharMap(tag.site.language)|json_encode|raw }}
170+
});
171+
{% endjs %}
172+
{% endif %}

src/web/assets/TagIndex.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ Craft.TagsIndex = Craft.BaseElementIndex.extend({
111111
for (let i = 0, l = this.editableGroups.length; i < l; ++i) {
112112
let group = this.editableGroups[i];
113113

114-
if (isIndex || group.id !== selectedGroup.id) {
114+
if (isIndex || (selectedGroup && group.id !== selectedGroup.id)) {
115115
href = this._getGroupTriggerHref(group);
116116
label =
117117
isIndex

0 commit comments

Comments
 (0)