fix(updates): use cache for checking for updates

Author: kentcdodds

packages/workshop-app/app/root.tsx

@@ -12,7 +12,7 @@ import {
 	getUserInfo,
 	userHasAccessToWorkshop,
 } from '@epic-web/workshop-utils/epic-api.server'
-import { checkForUpdates } from '@epic-web/workshop-utils/git.server'
+import { checkForUpdatesCached } from '@epic-web/workshop-utils/git.server'
 import { makeTimings } from '@epic-web/workshop-utils/timing.server'
 import {
 	getSetClientIdCookieHeader,
@@ -122,7 +122,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
 		user: getUserInfo(),
 		userHasAccess: userHasAccessToWorkshop({ request, timings }),
 		apps: getApps({ request, timings }),
-		repoUpdates: checkForUpdates(),
+		repoUpdates: checkForUpdatesCached(),
 		unmutedNotifications: getUnmutedNotifications(),
 	})
 

packages/workshop-app/app/routes/admin+/update-repo.tsx

@@ -1,6 +1,6 @@
 import { spawn } from 'child_process'
 import {
-	checkForUpdates,
+	checkForUpdatesCached,
 	updateLocalRepo,
 } from '@epic-web/workshop-utils/git.server'
 import { json } from '@remix-run/node'
@@ -9,7 +9,7 @@ import { useEffect, useRef } from 'react'
 import { toast } from 'sonner'
 
 export async function action() {
-	const updates = await checkForUpdates()
+	const updates = await checkForUpdatesCached()
 	if (!updates.updatesAvailable) {
 		return json({ type: 'error', error: 'No updates available' } as const, {
 			status: 400,

packages/workshop-app/server/index.ts

@@ -8,7 +8,7 @@ import {
 	init as initApps,
 	setModifiedTimesForAppDirs,
 } from '@epic-web/workshop-utils/apps.server'
-import { checkForUpdates } from '@epic-web/workshop-utils/git.server'
+import { checkForUpdatesCached } from '@epic-web/workshop-utils/git.server'
 import { checkConnectionCached } from '@epic-web/workshop-utils/utils.server'
 import { createRequestHandler } from '@remix-run/express'
 import { type ServerBuild } from '@remix-run/node'
@@ -50,7 +50,7 @@ const epicshopAppRootDir = isRunningInBuildDir
 	: path.join(__dirname, '..')
 
 // kick this off early...
-const hasUpdatesPromise = checkForUpdates()
+const hasUpdatesPromise = checkForUpdatesCached()
 // warm up some caches
 void getApps()
 void checkConnectionCached()

packages/workshop-utils/src/git.server.ts

@@ -1,5 +1,6 @@
 import { execa, execaCommand } from 'execa'
 import { getWorkshopRoot } from './apps.server.js'
+import { cachified, checkForUpdatesCache } from './cache.server.js'
 import { getWorkshopConfig } from './config.server.js'
 import { getErrorMessage } from './utils.js'
 import { checkConnection } from './utils.server.js'
@@ -87,6 +88,17 @@ export async function checkForUpdates() {
 	}
 }
 
+export async function checkForUpdatesCached() {
+	const key = 'checkForUpdates'
+	return cachified({
+		ttl: 1000 * 60,
+		swr: 1000 * 60 * 60 * 24,
+		key,
+		getFreshValue: checkForUpdates,
+		cache: checkForUpdatesCache,
+	})
+}
+
 export async function updateLocalRepo() {
 	const cwd = getWorkshopRoot()
 	try {