fix: Clarify workshop directory search errors (#590)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Author: kentcdodds

packages/workshop-mcp/src/utils.test.ts

@@ -164,8 +164,12 @@ test('handleWorkshopDirectory normalizes playground to workshop root', async ()
 test('handleWorkshopDirectory rejects when no workshop directory found (aha)', async () => {
 	await using fixture = await createTempDir()
 	vi.mocked(console.error).mockImplementation(() => {})
+	const searchStartDirectory = path.join(fixture.root, 'nested', 'deeper')
+	const filesystemRoot = path.parse(searchStartDirectory).root
 
-	await expect(handleWorkshopDirectory(fixture.root)).rejects.toThrow(
-		/No workshop directory found/,
+	await mkdir(searchStartDirectory, { recursive: true })
+
+	await expect(handleWorkshopDirectory(searchStartDirectory)).rejects.toThrow(
+		`No workshop directory found while searching upward from "${searchStartDirectory}" to filesystem root "${filesystemRoot}"`,
 	)
 })

packages/workshop-mcp/src/utils.ts

@@ -48,10 +48,14 @@ export async function handleWorkshopDirectory(workshopDirectory: string) {
 		workshopDirectory = path.join(workshopDirectory, '..')
 	}
 
+	const searchStartDirectory = workshopDirectory
+
 	while (true) {
 		if (await isWorkshopDirectory(workshopDirectory)) break
 		if (workshopDirectory === path.dirname(workshopDirectory)) {
-			throw new Error(`No workshop directory found in "${workshopDirectory}"`)
+			throw new Error(
+				`No workshop directory found while searching upward from "${searchStartDirectory}" to filesystem root "${workshopDirectory}"`,
+			)
 		}
 		workshopDirectory = path.dirname(workshopDirectory)
 	}